Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page: move components from brave-ui to brave-core #5178

Closed
petemill opened this issue Jul 8, 2019 · 1 comment · Fixed by brave/brave-core#2857
Closed

New Tab Page: move components from brave-ui to brave-core #5178

petemill opened this issue Jul 8, 2019 · 1 comment · Fixed by brave/brave-core#2857

Comments

@petemill
Copy link
Member

petemill commented Jul 8, 2019

The NTP components are specific to brave-core. It will be more productive to have these inside the brave-core repo rather than in a separate repo (brave-ui).

Reasoning and steps explained in #2335

Test Plan

NTP works

  • Open NTP
  • Check renders and no console errors
@LaurenWags
Copy link
Member

LaurenWags commented Aug 23, 2019

Verified passed with

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Verified test plan from description

Verification passed on

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS
  • Verified test plan from the description

Verification passed on

Brave 0.69.113 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from the description

tmancey pushed a commit that referenced this issue Apr 9, 2020
…option_fix_1.8.x

Fixed 3rd party cookies blocking behavior (uplift to 1.8.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment