Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: move components from brave-ui to brave-core #5198

Closed
cezaraugusto opened this issue Jul 9, 2019 · 1 comment · Fixed by brave/brave-core#2888
Closed

Sync: move components from brave-ui to brave-core #5198

cezaraugusto opened this issue Jul 9, 2019 · 1 comment · Fixed by brave/brave-core#2888
Assignees
@cezaraugusto
Labels
about-pages/sync dev-experience QA/No release-notes/exclude
Milestone
1.4.x - Release

Comments

@cezaraugusto
Copy link
Contributor

(details here adapted originally from #5178)

Sync components are specific to brave-core. It will be more productive to have these inside the brave-core repo rather than in a separate repo (brave-ui).

Reasoning and steps explained in #2335

Test Plan

  • Open Sync
  • Check renders and no console errors
@cezaraugusto cezaraugusto self-assigned this Jul 9, 2019
@cezaraugusto cezaraugusto mentioned this issue Jul 10, 2019
Merged
@petemill petemill mentioned this issue Jul 10, 2019
Closed
7 tasks
@simonsan simonsan mentioned this issue Aug 12, 2019
Closed
@cezaraugusto cezaraugusto added this to the 1.4.x - Nightly milestone Dec 11, 2019
@cezaraugusto cezaraugusto added QA/No and removed QA/Yes labels Dec 12, 2019
@cezaraugusto
Copy link
Contributor Author

Setting this as QA/no since no functional or visual changes were applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/sync dev-experience QA/No release-notes/exclude
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Sync: Move from brave-ui to brave-core brave/brave-core
1 participant
@cezaraugusto