Sync: Move from brave-ui to brave-core #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
b88775e
to
4c99d48
Compare
7 tasks
AlexeyBarabash
previously approved these changes
Jul 10, 2019
cezaraugusto
force-pushed
the
brave-ui-sync
branch
3 times, most recently
from
26129ec
to
985c136
Compare
|
cc @petemill could you check this one? |
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
985c136
to
ddc15a5
Compare
petemill
previously requested changes
Jul 17, 2019
There was a problem hiding this comment.
This all looks great @cezaraugusto
Just one change would be good - please update the storybook name. Right now it's a couple 'levels' deep (creating a 'Feature Components' level).
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
ddc15a5
to
ac8bd15
Compare
|
ok updated |
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
ac8bd15
to
75a103c
Compare
|
also rebased |
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
75a103c
to
f6e5e60
Compare
|
rebased again |
|
Any update on this? |
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
be09e4b
to
e547ebd
Compare
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
e547ebd
to
62793c9
Compare
- updated text strings for buttons and paragraphs. few grammatical changes - general aesthetic tweaks to typography and coloring - updated 3 icons that were not rendering correctly - updated input type to be body copy
…Content table rows
… sync tableGrid component
…de, use proper flow for sync words
- updated illustrations from png to svg - updated a few small locale strings - removed clipboard from target computer code entry
Updating the usage of the verb
… instances of Card, so that Card is free to have content in a separate element Necessary for upcoming header / footer element that should be distinct from the content padding. Note that new property is provided allowing the caller to provide their own padding via a content element.
cezaraugusto
force-pushed
the
brave-ui-sync
branch
from
c5e2dd5
to
d971dac
Compare
|
@AlexeyBarabash thanks, rebased the first 5 commits. could you pls re-check? |
AlexeyBarabash
approved these changes
Dec 11, 2019
cezaraugusto
added a commit
that referenced
this pull request
Feb 3, 2020
Close brave/brave-browser#8022 Sync was removed from brave-ui in brave/brave-ui#552 and added to brave-core in #2888. Now, paths in brave-core need update as well.
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address brave/brave-browser#2335
close brave/brave-browser#5198
Test Plan