Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorder items in the App menu #5552

Closed
rebron opened this issue Aug 6, 2019 · 2 comments · Fixed by brave/brave-core#4235
Closed

reorder items in the App menu #5552

rebron opened this issue Aug 6, 2019 · 2 comments · Fixed by brave/brave-core#4235
Assignees
@simonhong
Labels
design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.4.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 6, 2019 •
edited by bsclifton
Loading

Description (Test plan)

App menu should be ordered like the following:

  • Brave Rewards
  • History ->
  • Bookmarks ->
  • Downloads
  • Crypto Wallets [new]
  • Extensions [pulled out from More Tools sub-menu]
  • Sync
  • Brave Ad Block [for now and may move into Settings in the future]

Design

Screen Shot 2019-08-07 at 3 57 12 AM
@rebron rebron added the design A design change, especially one which needs input from the design team label Aug 6, 2019
@petemill petemill self-assigned this Aug 6, 2019
@rebron
Copy link
Collaborator Author

rebron commented Aug 6, 2019

For now, pull 'Extensions' out of sub-menu, use 'Extensions' label and place under Crypto Wallets per the screenshot.

@petemill petemill mentioned this issue Aug 6, 2019
Merged
32 tasks
@kjozwiak kjozwiak added the QA/Yes label Aug 7, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 16, 2019
@rebron rebron assigned simonhong and unassigned petemill Dec 10, 2019
@simonhong simonhong mentioned this issue Dec 15, 2019
Merged
32 tasks
simonhong added a commit to brave/brave-core that referenced this issue Dec 15, 2019
@simonhong
Re-order brave menus at app menu
a5cc65d 
Insert & reorder brave menus based on corresponding commands enable status.
If we want to add/remove from app menu, adjust enable commands status
instead of adjusting it in app menu model directly.
App menu model will add/delete based on commands status.

Fix brave/brave-browser#5552
@simonhong simonhong added this to the 1.4.x - Nightly milestone Dec 15, 2019
simonhong added a commit to brave/brave-core that referenced this issue Dec 18, 2019
@simonhong
Re-order brave menus at app menu
dfa3dfb 
Insert & reorder brave menus based on corresponding commands enable status.
If we want to add/remove from app menu, adjust enable commands status
instead of adjusting it in app menu model directly.
App menu model will add/delete based on commands status.

Fix brave/brave-browser#5552
@kjozwiak kjozwiak mentioned this issue Dec 19, 2019
Closed
35 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Jan 22, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.4.66 Chromium: 79.0.3945.130 (Official Build) dev (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified Normal Window

5552-NormalWindow

  • Verified Private Window

5552-PrivateWindow

  • Verified Tor Window

5552-TorWindow

  • Verified Guest Window

5552-GuestWindow

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

  • Verified Normal Window
    image

  • Verified Private Window
    image

  • Verified Tor Window
    image

  • Verified Guest Window
    image

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified Normal Window
    image

  • Verified Private Window
    image

  • Verified Tor Window
    image

  • Verified Guest Window
    image

@kjozwiak kjozwiak mentioned this issue Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Re-order brave menus at app menu brave/brave-core
8 participants
@petemill @kjozwiak @bsclifton @rebron @simonhong @LaurenWags @btlechowski @GeetaSarvadnya