-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-order brave menus at app menu #4235
Conversation
@rebron I added |
0c4c110
to
a5cc65d
Compare
4586783
to
fbc5cb3
Compare
@simonhong |
Linux got the and Windows had a build error; going to restart CI for those two platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested + changes work great; code changes LGTM (pending CI) 👍
Hmm, still glibc issue on linux. |
Insert & reorder brave menus based on corresponding commands enable status. If we want to add/remove from app menu, adjust enable commands status instead of adjusting it in app menu model directly. App menu model will add/delete based on commands status. Fix brave/brave-browser#5552
and cleanup brave app menu test.
fbc5cb3
to
ae5f3d8
Compare
Insert & reorder brave menus based on corresponding commands enable status.
If we want to add/remove from app menu, adjust enable commands status
instead of adjusting it in app menu model directly.
App menu model will add/delete based on commands status.
Fix brave/brave-browser#5552
Normal window app menu
Private window app menu
Tor window app menu
Guest window app menu
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.