support restoring from metamask words in crypto-wallet

[diracdeltas]

it should have an option for restore from metamask

[bbondy]

@diracdeltas are you working on this one?

[diracdeltas]

@bbondy haven't gotten around to it yet but i will today

[kjozwiak]

This isn't working correctly. Restoring a 12 word seed phrase from MM really screws up brave://wallet and puts it into an unstable state. Example:

Once you're in the above state, brave://wallets doesn't load correctly at times. Some of the buttons completely stop working so you can't even restore another wallet. If someone attempts to restore a MM seed phrase, they'll basically put brave://wallet into a bad state/unusable state.

[kjozwiak]

@diracdeltas I don't think this is working as per #5698 (comment). Current version of MM generates a 12 word seed but our UI mentions that it's not 16 words after you try importing:

[diracdeltas]

@kjozwiak got it - were you able to restore from 12 words sometimes (see #5698 (comment)) or not at all?

[srirambv]

@diracdeltas i was able to use the 12 words but it broke the wallet login and started showing MetamaskController - No HD Key Tree found

[diracdeltas]

i'll dig into this today. worst case we can change the UI back to not support metamask restoring?

[diracdeltas]

this might be broken because brave/eth-hd-keyring#4 was never merged. @bbondy or @ryanml mind re-approving and merging it?

[kjozwiak]

Verification PASSED on macOS 10.14.6 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.15 via the following build:

Brave	0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.14.6 (Build 18G95)

• created a wallet within MM and sent 0.0117 ETH & 10 BAT. Once the funds made into the wallet, restored the same wallet using the 12 word seed phrase from MM into CW and ensured the worked as expected. Once the wallet was restored within CW, sent 5 BAT into my Uphold account and ensured the transaction went through without issues.
• created a wallet within MM and sent 0.025 ETH & 25 BAT. Once the funds made into the wallet, restored the same wallet using the 12 word seed phrase from MM into CW and ensured the worked as expected. Once the wallet was restored within CW, sent 10 BAT into my Uphold account and ensured the transaction went through without issues.
• created a wallet within MM and sent 1 ETH using the Ropsten network and 3 ETH using the Rinkeby network. Once the funds made it into the wallet, restored the same wallet using the 12 word seed phrase from MM into CW and ensured the worked as expected.

Verification PASSED on Windows 10 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.15 via the following build:

Brave	0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1809 (Build 17763.737)

• restored MM wallet that was created previously that had 0.0246 ETH & 15 BAT within CW and ensured the correct amount was being displayed after restoring. Sent 10 BAT into my Uphold account and ensured the transaction went through without any issues using a restored wallet.
• restored MM wallet that was created previously that had 0.0113 ETH & 5 BAT within CW and ensured the correct amount was being displayed after restoring. Sent 5 BAT into my Uphold account and ensured the transaction went through without any issues using a restored wallet.
• restored MM wallet that was created previously that had 1 ETH using the Ropsten network and 3 ETH using the Rinkeby within CW and ensured the correct amount was being displayed after restoring.

[srirambv]

Verification passed on

Brave	0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Linux

• Sent BAT/ETH to MM account. Restored the same wallet in Brave CW and the balance was restored in Brave CW
• Created an empty wallet on MM. Restored the same wallet on Brave CW. Sent BAT/ETH to MM account, balance showed up on Brave CW
• Verified sending 3 BAT to uphold account was successfull on a restored MM wallet on Brave CW