Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue (0.69): Default state for connected creators needs backward compatibility #5925

Closed
mandar-brave opened this issue Sep 6, 2019 · 2 comments · Fixed by brave/brave-core#3399

Comments

@mandar-brave
Copy link

Context:
When the user wallets were introduced, we originally asked creators to be Brave-Connected (signed up with brave) and Uphold verified (KYC'd) to get tips (V2 API)

Midway through 0/69, we updated the release to support backward where minimally the Creators that were connected were shown as verified. However, the transactions for supporting the Brave-Connected creators were not in sync with the updated change (V2 -> V3 API).

Issue:
Creators that are Brave-connected but not verified are not getting any tips via users that are on browser wallet. They are held at the browser in escrow.

Fix:

  1. Users on browser (anon) wallets should be able to tip creators that are Brave connected but not Uphold KYC'd (supporting backward compatibility).
  2. Only users that are KYC'd should see the Creator-not-KYC'd message; else everyone should see creator-unverified message (so message needs to be state managed)

cc @NejcZdovc @LaurenWags @rebron @BrendanEich @davidtemkin

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Sep 6, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Release milestone Sep 7, 2019
@mandar-brave
Copy link
Author

Use this message when User has a user wallet (verified) encounters a connected creator but no KYC.

“For Panel
Expected text: This Brave Verified Creator has not yet configured their account to receive contributions from Brave Users. Any tips you send will remain in your wallet until they complete this process.

For Tipping Banner
Expected text: This Brave Verified Creator has not yet configured their account to receive contributions from Brave users. Your browser will keep trying to contribute until they verify, or until 90 days have passed.”

@NejcZdovc

@LaurenWags
Copy link
Member

LaurenWags commented Sep 26, 2019

Verified passed with

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

plan3-ss1

plan3-ss2

plan3-ss3

* Plan 4 passed:

plan4-ss1

plan4-ss2

plan4-ss3

* Plan 5 passed:

Screen Shot 2019-09-26 at 2 57 08 PM

Screen Shot 2019-09-26 at 2 57 20 PM

Screen Shot 2019-09-26 at 2 57 39 PM

Screen Shot 2019-09-26 at 2 58 02 PM

Screen Shot 2019-09-26 at 2 58 29 PM

* Also verified that non-verified creators still display the non-verified message on panel/tip banner and tip goes to Pending list:

Screen Shot 2019-09-26 at 3 36 05 PM

Screen Shot 2019-09-26 at 3 36 13 PM

Screen Shot 2019-09-26 at 3 36 30 PM

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

image

  • Plan 4 passed:

image

image

image

  • Plan 5 passed:

image

image

image

image

  • Also verified that non-verified creators still display the non-verified message on panel/tip banner and tip goes to Pending list:

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants