You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @mkarolin found, pulling in brave/brave-core#2957 fixes this, which was done on 0.69.x with c77 and fixed exactly the same test issues. What 2957 does is removes calls to SetWebUIProperty.
However, 0.68.x NTP is too far away from 0.70.x to easily merge 2957 (which is on 0.70).
disable those tests in 68 and hope we don't hit the error in real usage
Pro: extremely quick
Con: Not great to disable tests, and we still don't know why it's an issue. However, it does seem to only be affecting Guest (and possibly Tor) windows.
pull in 2957 to 68 and whatever else it needs (most of the 69 list)
Pro: fixes the issue
Con: bring in more untested features, although a known set affecting the NTP
Create a new version of 2957 against 68 that uses current 68 code
i.e. migrate 0.68 to not use SetWebUIProperty
Pro: only changes backend code, not bringing in new features
Description
When running browser tests, there are two failures
Steps to Reproduce
npm run test brave_browser_tests -- Release
Actual result:
Expected result:
No failures
Reproduces how often:
100%
The text was updated successfully, but these errors were encountered: