-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting options to toggle NTP widgets #2762
Conversation
f11e9bb
to
27f5750
Compare
848c7a2
to
626ce61
Compare
626ce61
to
69d037e
Compare
709c885
to
08f9353
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm adding @petemill as reviewer who suggested moving stored data to be in settings instead of using localStorage. I'm ok either doing that as a follow-up or holding this one a bit until we have the proper api exposed
@cezaraugusto I'm going to PR the change to either this, or to master if this is merged first. I'm happy with either scenario but if this is merged first, any users who change the setting will have their setting reset back to default once the prefstore change lands |
08f9353
to
4025c0c
Compare
Pushed a rebase on master. We'll still want to update brave-ui sha with the result of merging brave/brave-ui#503 when that happens |
Here's a branch which adds these remaining toggles to the pref store, for integrating perhaps by @imptrx when #2831 is merged to master and this is rebased. The branch is a rebase of this PR on that, and then adds the prefs. |
set PR as blocked until #2831 is resolved |
4025c0c
to
a456b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ great Peter work here! thanks team this is super cool. 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add a test plan and link to it from brave/brave-browser#4510 |
6fca56c
to
b613ed6
Compare
8afd24f
to
5324f20
Compare
Spec: brave/brave-browser#4510 (Current scope of this PR does not include right clicking on the widgets to open up a mini-menu)
Brave-ui Sister PR: brave/brave-ui#503
Quick View:
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.