Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Auto-Contribute to use "up to" budgeting, and to only contribute to verified content creators #6228

Closed
davidtemkin opened this issue Sep 30, 2019 · 1 comment · Fixed by brave/brave-core#3564
Closed

Change Auto-Contribute to use "up to" budgeting, and to only contribute to verified content creators #6228

davidtemkin opened this issue Sep 30, 2019 · 1 comment · Fixed by brave/brave-core#3564
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.70.x - Release

Comments

@davidtemkin
Copy link

davidtemkin commented Sep 30, 2019 •
edited by NejcZdovc
Loading

spec can be found in #spec
@NejcZdovc NejcZdovc mentioned this issue Sep 30, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 30, 2019
@NejcZdovc NejcZdovc added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Sep 30, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 3, 2019
@NejcZdovc
AC verified change
9036f88 
Resolves brave/brave-browser#6228
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 3, 2019
@NejcZdovc
AC verified change
006b76e 
Resolves brave/brave-browser#6228
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 8, 2019
@NejcZdovc
AC verified change
0cc1a94 
Resolves brave/brave-browser#6228
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 9, 2019
@NejcZdovc
AC verified change
1adfb44 
Resolves brave/brave-browser#6228
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 9, 2019
@NejcZdovc
AC verified change
a1e9855 
Resolves brave/brave-browser#6228
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 15, 2019
@NejcZdovc
AC verified change
4cdf493 
Resolves brave/brave-browser#6228
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 15, 2019
@NejcZdovc
AC verified change
db4146c 
Resolves brave/brave-browser#6228
@jhoneycutt jhoneycutt mentioned this issue Oct 15, 2019
Closed
This was referenced Oct 15, 2019
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 18, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan from AC contribution change brave-core#3564
  • Verified “Up to” text added to the left of the selected BAT amount for Monthly Payment dropdown items in Auto-Contribute panel
  • Verified auto-contribution happens only for verified pubs when verified and non-verified sites are added into a-c table, also non-verified pubs will not be listed in pending contribution list anymore
  • Verified auto-contributions will not happen when only non-verified creators are added into a-c table, wallet balance will not change and non-verified pubs will not be listed in pending contribution list after auto-contribution
  • Verified the text change “The Brave Verified sites you visit will receive your contributions automatically, based on your attention as measured by Brave” reflected in the Auto-Contribution panel
  • Verified few label changes are not yet done. Encountered label changes for Auto Contribute - follow up to 6228 #6483
  • Verified that one-time tip and recurring monthly tip for non-verified pubs still displayed in the pending contribution list table
  • Verified that the upgraded profile Pending contribution list has Auto contribute entry for non-verified pubs

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS
  • Verified the test plan from AC contribution change brave-core#3564
  • Verified “Up to” text added to the left of the selected BAT amount for Monthly Payment dropdown items in Auto-Contribute panel
  • Verified auto-contribution happens only for verified pubs when verified and non-verified sites are added into a-c table, also non-verified pubs will not be listed in pending contribution list anymore
  • Verified auto-contributions will not happen when only non-verified creators are added into a-c table, wallet balance will not change and non-verified pubs will not be listed in pending contribution list after auto-contribution
  • Verified the text change “The Brave Verified sites you visit will receive your contributions automatically, based on your attention as measured by Brave” reflected in the Auto-Contribution panel
  • Verified few label changes are not yet done. Encountered label changes for Auto Contribute - follow up to 6228 #6483
  • Verified that one-time tip and recurring monthly tip for non-verified pubs still displayed in the pending contribution list table
  • Verified that the upgraded profile Pending contribution list has Auto contribute entry for non-verified pubs

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.14.6 (Build 18G95)
  • Verified the test plan from AC contribution change brave-core#3564
  • Verified “Up to” text added to the left of the selected BAT amount for Monthly Payment dropdown items in Auto-Contribute panel
  • Verified auto-contribution happens only for verified pubs when verified and non-verified sites are added into a-c table, also non-verified pubs will not be listed in pending contribution list anymore
  • Verified auto-contributions will not happen when only non-verified creators are added into a-c table, wallet balance will not change and non-verified pubs will not be listed in pending contribution list after auto-contribution
  • Verified the text change “The Brave Verified sites you visit will receive your contributions automatically, based on your attention as measured by Brave” reflected in the Auto-Contribution panel
  • Verified few label changes are not yet done. Encountered label changes for Auto Contribute - follow up to 6228 #6483
  • Verified that one-time tip and recurring monthly tip for non-verified pubs still displayed in the pending contribution list table
  • Verified that the upgraded profile Pending contribution list has Auto contribute entry for non-verified pubs

@LaurenWags LaurenWags mentioned this issue Oct 18, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Oct 22, 2019
Closed
82 tasks
@kjozwiak kjozwiak mentioned this issue Oct 23, 2019
Closed
@karenkliu karenkliu mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

AC contribution change brave/brave-core
8 participants
@kjozwiak @jenn-rhim @davidtemkin @NejcZdovc @LaurenWags @btlechowski @mandar-brave @GeetaSarvadnya