Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tip panel wording - follow up to 6228 #6484

Closed
LaurenWags opened this issue Oct 15, 2019 · 7 comments · Fixed by brave/brave-core#3727
Closed

update tip panel wording - follow up to 6228 #6484

LaurenWags opened this issue Oct 15, 2019 · 7 comments · Fixed by brave/brave-core#3727
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards needs-text-change This change requires some careful wording. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

With the changes in #6228 and #6288, and a new Monthly Contribution panel on brave://rewards, should the Tip panel text which mentions recurring monthly tips be updated?

Steps to Reproduce

  1. Clean profile 0.72.102
  2. Navigate to brave://rewards page
  3. Enable Rewards
  4. Scroll to Tips panel. Panel text mentions "You can also set up recurring monthly tips so you can support sites continuously." and "Support your favorite sites with recurring monthly tips."
  5. Refresh page.
  6. View Tips panel. Panel tex mentions "You can also set up recurring monthly tips so you can support sites continuously."

Actual result:

Screen Shot 2019-10-15 at 3 29 21 PM

Screen Shot 2019-10-15 at 3 28 16 PM

Expected result:

Unsure if text should be updated or removed.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.72.102 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @davidtemkin @NejcZdovc @rebron @kjozwiak

@LaurenWags
Copy link
Member Author

For reference, this is what the current Monthly Contributions (monthly recurring tips) panel looks like:
Screen Shot 2019-10-15 at 3 45 50 PM
Screen Shot 2019-10-15 at 3 46 00 PM

@LaurenWags
Copy link
Member Author

cc @jenn-rhim

@NejcZdovc NejcZdovc added design A design change, especially one which needs input from the design team needs-text-change This change requires some careful wording. 1.0-suggestion labels Oct 15, 2019
@bradleyrichter
Copy link

bradleyrichter commented Oct 16, 2019

@LaurenWags @ryanml @mandar-brave

Here is the new text:

image

image

Monthly Contributions
Set up recurring monthly contributions so you can support sites continuously.

Your monthly contributions will be sent every 30 days.


Tips
Tip content creators directly as you browse by using the Rewards Panel, or by using the inline tip button on various sites including Twitter, Reddit and GitHub.

Tip on the spot as you find gems.

If you like, let people know with a quick tweet.

@btlechowski
Copy link

btlechowski commented Nov 4, 2019

@bsclifton @ryanml @kjozwiak Should this be uplifted to 0.71.x? 0.71.x uses old Rewards layout. It doesn't even have Monthly Contributions section in brave://rewards.

Edit: After change, it look like this:
image
image

Edit2: the text is not translated to other languages
image

@bradleyrichter
Copy link

@rebron ^

@NejcZdovc
Copy link
Contributor

again I don't know why this was uplifted to 0.71 as original implementation was done in 0.72. What we now uplifted in not relevant to .71

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 5, 2019

Per discussion in todays triage mtg, we are keeping these text changes in 0.71.x.

Verified Tips panel text with 0.71.x:

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

rewards-disabled-tip-text
Screen Shot 2019-11-05 at 5 23 19 PM

Verified Monthly Contributions panel text with 0.72.x as it is not available in 0.71.x:

Brave 0.72.117 Chromium: 78.0.3904.87 (Official Build) dev (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-11-05 at 5 22 12 PM

Screen Shot 2019-11-05 at 5 23 29 PM

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

image
image

Verification passed on

Brave 0.72.119 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

image
image

Verification passed on

Brave 0.71.113 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image
image

Verification passed on

Brave 0.72.121 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards needs-text-change This change requires some careful wording. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants