Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connecting to bravesoftware.com (a hijackable domain) on startup #662

Closed
diracdeltas opened this issue Jul 31, 2018 · 2 comments
Closed

Comments

@diracdeltas
Copy link
Member

I started brave with a firewall and noticed it was connecting to https://updates.bravesoftware.com. This is a potential security issue since bravesoftware.com is currently not owned by us and an attacker could buy it at any point for $199 or more.

screen shot 2018-07-30 at 8 00 34 pm

Looks like the code that sets this is https://github.com/brave/brave-core/blob/c07c305137b2c471f42535bbc74cf7d91ad1c149/build/config.gni#L27

@diracdeltas diracdeltas changed the title connecting to bravesoftware.com (an unregistered domain) on startup connecting to bravesoftware.com (a hijackable domain) on startup Jul 31, 2018
@diracdeltas
Copy link
Member Author

cc @simonhong @RyanJarv

@diracdeltas
Copy link
Member Author

confirmed with @RyanJarv that actually we do own the domain. namecheap is just very aggressive about getting people to bid on domains. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants