-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing "Choose a type to set up" from brave://wallet #7791
Closed
Labels
Milestone
Comments
kjozwiak
added
QA/Yes
QA/Test-Plan-Specified
feature/web3/wallet
Integrating Ethereum+ wallet support
labels
Jan 17, 2020
This was referenced Feb 3, 2020
Verification passed on
Verification passed on
Verification passed on
|
srirambv
added
feature/ethereum-remote-client
and removed
feature/web3/wallet
Integrating Ethereum+ wallet support
labels
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
As discussed earlier on Slack, we should probably remove the
Choose a type to set up:
text frombrave://wallet
. It's obvious that the user needs to select one of the below options. The options also have detailed descriptions. Seems like unnecessary text that can be removed.This will also resolve part of the translation issue mentioned via #6533.
Steps to Reproduce
brave://wallet
I understand
under theWelcome to Brave Crypto Wallets
modalActual result:
Expected result:
The
Choose a type to set up:
should be removed.Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Version/Channel Information:
N/A
N/A
N/A
N/A
Other Additional Information:
N/A
N/A
N/A
Miscellaneous Information:
CCing @ryanml @srirambv
The text was updated successfully, but these errors were encountered: