Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "Choose a type to set up" from brave://wallet #7791

Closed
kjozwiak opened this issue Jan 17, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#110
Closed

Removing "Choose a type to set up" from brave://wallet #7791

kjozwiak opened this issue Jan 17, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#110

Comments

@kjozwiak
Copy link
Member

Description

As discussed earlier on Slack, we should probably remove the Choose a type to set up: text from brave://wallet. It's obvious that the user needs to select one of the below options. The options also have detailed descriptions. Seems like unnecessary text that can be removed.

This will also resolve part of the translation issue mentioned via #6533.

Steps to Reproduce

  1. launch brave and visit brave://wallet
  2. Select I understand under the Welcome to Brave Crypto Wallets modal

Actual result:

Screen Shot 2020-01-10 at 2 13 39 PM

Expected result:

The Choose a type to set up: should be removed.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the dev channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @ryanml @srirambv

@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2020

Verification passed on

Brave 1.5.73 Chromium: 80.0.3987.66 (Official Build) nightly (64-bit)
Revision 56ea77d65c47ecbb1180b99f860d85b51117864a-refs/branch-heads/3987@{#662}
OS Linux
Component 0.1.37
  • Verified Choose a type to set up text is removed
    image

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42
  • Verified Choose a type to set up text is removed
    image

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment