New window in private window with tor no longer opens new window with tor

[btlechowski]

New window in private window with tor used to open a new window with tor. This is no longer the case.

Steps to Reproduce

1. Clean install
2. Open a private window with tor
3. In private window with tor click New window from Hamburger menu

Actual result:

Normal new window is opened

Important: if #6467 is fixed as intended in #6467 (comment), there will be no way of opening a new private window with tor from private window with tor.

Expected result:

New private window with tor is opened

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel? yes
• Can you reproduce this issue with the nightly channel?

cc @brave/legacy_qa @bsclifton @rebron @yrliou @tomlowenthal

[yrliou]

From slack discussion, our goal is to have the ability to open any type of new windows(regular/private/private with Tor) in Tor window. So I'll fix this issue by showing New Window, New Private Window, and New Private Window with Tor in the hamburger menu and opening the corresponding type of window for each option.

[yrliou]

See brave/brave-core#3813 (comment) for the test plan.

[btlechowski]

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3813

regular window

private window

private window with Tor

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified STR from the description
• Verified test plan from Support opening new regular, private, private with Tor window in Tor window brave-core#3813
• Verified all new types of new window options displayed in the created new profile
• No change in the Guest window options

Normal window:

Private window:

Private window with TOR:

Verified passed with

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Support opening new regular, private, private with Tor window in Tor window brave-core#3813
• Verified able to open Normal, Private, Private with Tor windows from hamburger menu on each window type.
• Verified able to open Normal, Private, Private with Tor windows from macOS file menu on each window type.
• Encountered and logged unable to open New Private Window with Tor from file menu if no windows open - follow up to 6646 #6926