Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to open New Private Window with Tor from file menu if no windows open - follow up to 6646 #6926

Open
LaurenWags opened this issue Nov 14, 2019 · 0 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 14, 2019

Description

Found while testing #6646

If you do not have any windows open but have not quit the Brave application, when you go to the file menu (macOS), the option to open New Private Window with Tor is grayed out. The keyboard shortcut does not work either.

Steps to Reproduce

  1. Launch Brave.
  2. Close any open windows, but do not quit the application.
  3. Click on the File menu.

Actual result:

New Private Window with Tor is grayed out. The keyboard shortcut does not work either.
Screen Shot 2019-11-14 at 11 15 59 AM

Expected result:

Option not grayed out, keyboard shortcut should work.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants