Private window w/ Tor shows "new private window"

[bsclifton]

Description

While testing brave/brave-core#3686, I noticed a weird regression - cc: @yrliou who has done Tor work in Nightly (it may be due to that work? or Chromium 78? not sure)

Basically, in Dev channel for example (C77), when in a private window with Tor, you're not given the option to create a regular private window

• via the hamburger menu
  
• via the menu (macOS)
  

On master/Nightly, when in a private window with Tor, you're shown the option to open a new private window. If you do choose this, it opens a private window with Tor, NOT a regular private window.

• hamburger menu
  
• via the menu (macOS)
  

Steps to Reproduce

1. Launch master / Nightly
2. Open a new private window with Tor
3. Use hamburger menu, pick New Private Window

Actual result:

A new private window with Tor is shown

Expected result:

Menu option should not be there (see screenshot)

Reproduces how often:

100%

Brave version (brave://version info)

master/Nightly (0.72.x)

Version/Channel Information:

• Can you reproduce this issue with the current release? n
• Can you reproduce this issue with the beta channel? n
• Can you reproduce this issue with the dev channel? n
• Can you reproduce this issue with the nightly channel? y

[btlechowski]

Reproduced on Ubuntu

Brave	0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa

[yrliou]

Had a discussion with @tomlowenthal and @bsclifton through slack, we will keep the New private window in Tor windows but tweak its behavior to open a private window in its parent profile instead of Tor profile.

[btlechowski]

Because of #6646 if this issue is fixed as intended in #6467 (comment), there will be no way of opening a new private window with tor from private window with tor.

[yrliou]

@btlechowski Right, I think I'll also fix the New window in the same PR.

[yrliou]

See brave/brave-core#3813 (comment) for the test plan.

[btlechowski]

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3813

regular window

private window

private window with Tor

Verified passed with

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Support opening new regular, private, private with Tor window in Tor window brave-core#3813
• Verified able to open Normal, Private, Private with Tor windows from hamburger menu on each window type.
• Verified able to open Normal, Private, Private with Tor windows from macOS file menu on each window type.
• Encountered and logged unable to open New Private Window with Tor from file menu if no windows open - follow up to 6646 #6926

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Support opening new regular, private, private with Tor window in Tor window brave-core#3813
• Verified able to open Normal, Private, Private with Tor windows from the hamburger menu on each window type.
  Normal window:
  
  Private window:
  
  Private window with TOR: