Notifications are not shown on macOS caused by #3651 (Nightly only)

[tmancey]

Description

Notifications are not shown on macOS caused by #3651 (Nightly only)

Steps to Reproduce

1. View ad

Actual result:

Ad notification is not shown

Expected result:

Ad notification should be shown

Reproduces how often:

Easily reproduced once you have a code-signed official build (not reproducible without as notifications require a code-signed build)

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the dev channel? No
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[btlechowski]

@tmancey Is this issue QA/Yes? Is it OS/macOS only?

[kjozwiak]

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave	1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.15.2 (Build 19C57)

• ensured that ad notifications were being displayed when Alerts was being used under Notifications in the macOS preferences
• ensured that ad notifications were being dismissed after 2mins when Alerts was being used
• ensured that ad notifications were being displayed when Banner was being used under Notifications in the macOS preferences
• ensured that ad notifications were being dismissed after 5sec when Alerts was being used
• ensured that ad notifications are not being displayed when None is selected under Notifications

Ensured that ad notifications were being generated:

[49771:775:0116/101551.368791:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"notify","stamp":"2020-01-16T10:15:51Z","notificationType":"generated","notificationClassification":["technology & computing"],"notificationCatalog":"c7f96341-726f-4e5d-9494-5686db89664b","notificationUrl":"https://vault.coinve.st/"}}
[49771:775:0116/101551.369072:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"confirmation","stamp":"2020-01-16T10:15:51Z","notificationId":"289ef146-8694-42a5-9023-db7fbad3d726","notificationType":"view"}}
[49784:775:0116/101551.369219:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: ce62887e-c1c3-46be-b6c4-d3e952cd3db4
  creative_set_id: c7f96341-726f-4e5d-9494-5686db89664b
  advertiser: Coinvest Vault
  category: technology & computing
  text: Pre-order the Founders Limited Edition Coinvest Vault today.
  url: https://vault.coinve.st/
  uuid: 289ef146-8694-42a5-9023-db7fbad3d726
  type: view

Ensured that you were able to click on ads:

[49771:775:0116/101554.278282:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"notify","stamp":"2020-01-16T10:15:54Z","notificationType":"clicked","notificationClassification":["technology & computing"],"notificationCatalog":"c7f96341-726f-4e5d-9494-5686db89664b","notificationUrl":"https://vault.coinve.st/"}}
[49771:775:0116/101554.278318:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"confirmation","stamp":"2020-01-16T10:15:54Z","notificationId":"289ef146-8694-42a5-9023-db7fbad3d726","notificationType":"click"}}
[49784:775:0116/101554.278450:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: ce62887e-c1c3-46be-b6c4-d3e952cd3db4
  creative_set_id: c7f96341-726f-4e5d-9494-5686db89664b
  advertiser: Coinvest Vault
  category: technology & computing
  text: Pre-order the Founders Limited Edition Coinvest Vault today.
  url: https://vault.coinve.st/
  uuid: 289ef146-8694-42a5-9023-db7fbad3d726
  type: click

Ensured that you were able to dismiss an ad:

[49771:775:0116/103254.592471:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"notify","stamp":"2020-01-16T10:32:54Z","notificationType":"dismissed","notificationClassification":["technology & computing"],"notificationCatalog":"c7f96341-726f-4e5d-9494-5686db89664b","notificationUrl":"https://vault.coinve.st/"}}
[49771:775:0116/103254.592841:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"confirmation","stamp":"2020-01-16T10:32:54Z","notificationId":"ada4e564-e0cc-4b20-aeb2-a9664792a7cc","notificationType":"dismiss"}}
[49784:775:0116/103254.593018:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: bc481e5d-1a3c-49d7-b63b-cc99bdb9ecea
  creative_set_id: c7f96341-726f-4e5d-9494-5686db89664b
  advertiser: Coinvest Vault
  category: technology & computing
  text: A premium digital assets hardware wallet. Pre-order today.
  url: https://vault.coinve.st/
  uuid: ada4e564-e0cc-4b20-aeb2-a9664792a7cc
  type: dismiss

Ensured that the ad notification are being dismissed after 2mins:

[49771:775:0116/110138.259110:INFO:ads_service_impl.cc(2105)] AdsService Event Log: {"data":{"type":"notify","stamp":"2020-01-16T11:01:38Z","notificationType":"timeout","notificationClassification":["technology & computing"],"notificationCatalog":"c7f96341-726f-4e5d-9494-5686db89664b","notificationUrl":"https://instant.airswap.io"}}

Examples of the notifications appearing on macOS