Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weekly stats ping (uplift to 0.70.x) #3651

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 10, 2019

Uplift of #3648

@emerick emerick added this to the 0.70.x - Beta milestone Oct 10, 2019
@emerick emerick self-assigned this Oct 10, 2019
@bsclifton bsclifton requested review from NejcZdovc and a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv October 10, 2019 16:06
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @NejcZdovc - this approach looks good! Discussion with approvers was 👍

CI looks like a failure, but it was actually yellow. npm run audit_deps failed because there was a blip in connectivity between the machine and npm

@bsclifton bsclifton merged commit 76dc611 into 0.70.x Oct 10, 2019
@bsclifton bsclifton deleted the incorrect-weekly-pings_0.70.x branch October 10, 2019 16:09
tmancey added a commit that referenced this pull request Nov 6, 2019
Fix user earns while native Windows and macOS notifications are suppressed
tmancey added a commit that referenced this pull request Nov 7, 2019
Notifications are not shown on macOS caused by #3651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants