-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate copies of Google fonts in the repo #6832
Comments
This causes Muli to appear twice in |
The two Same with the |
@fmarier It seems that test plan from brave/brave-core#4004 requires dev environment. Is there a way to test without it? #6881 has already been verified. Maybe it is enough? |
The alternative is to look at the various pages (listed in the PR) where we use the fonts and check that they "look right". I thought I wouldn't necessarily notice if the fonts had changed which is why I hacked the colors in my test. Maybe someone with a good eye for fonts can double-check that everything looks right in Beta? |
I tried to see but I am blind! Verified to the best of my ability (#6832 (comment)) Verification passed on
I used dev tools to check fonts from the list from brave/brave-core#4004 Verification PASSED on
Verification passed on
|
We have two copies of the Muli and Poppins fonts in
brave-core
:Presumably one of these could refer to the other one.
The text was updated successfully, but these errors were encountered: