Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6832 and brave/brave-browser#6881.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
I added some borders in the existing files:
so that I could see red borders on:
brave://rewards
brave://welcome
brave://sync
and blue ones on:
brave://settings
brave://history
After my change, everything looked blue, as expected. I then applied a similar patch for the other font:
and looked for green borders instead of red, and yellow borders instead of blue.
After my patch, everything went yellow as expected, except for WebTorrent which doesn't use Poppins for some reason.
Finally, I also verified that I hadn't broken the following:
chrome://brave-resources/fonts/muli.css
chrome://brave-resources/fonts/poppins.css
Reviewer Checklist:
After-merge Checklist:
changes has landed on.