Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adp-xfiles license #6910

Closed
fmarier opened this issue Nov 13, 2019 · 4 comments · Fixed by brave/brave-core#3991
Closed

Add adp-xfiles license #6910

fmarier opened this issue Nov 13, 2019 · 4 comments · Fixed by brave/brave-core#3991

Comments

@fmarier
Copy link
Member

fmarier commented Nov 13, 2019

Now that abp-xfiles has added a LICENSE file to the repo (gioxx/xfiles#7), we should add it to brave-core.

@btlechowski
Copy link

btlechowski commented Nov 28, 2019

Verification passed on

Brave 1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3991

image

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-07 at 2 47 17 PM

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

fmarier added a commit to brave/brave-core that referenced this issue Dec 4, 2019
fmarier added a commit to brave/brave-core that referenced this issue Dec 5, 2019
@LaurenWags
Copy link
Member

@fmarier not seeing this on macOS, is this expected? not sure if this license is OS specific?
Screen Shot 2020-01-07 at 11 38 38 AM

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

@fmarier
Copy link
Member Author

fmarier commented Jan 7, 2020

@LaurenWags The behavior when #7150 got fixed and uplifted.

The license for ABP X Files is now in the "Brave Ad Block" section:

Screenshot from 2020-01-07 11-14-58

@LaurenWags
Copy link
Member

gotcha, thanks @fmarier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants