Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a distinction between bundled third-parties and external third-party dependencies #7150

Closed
fmarier opened this issue Nov 28, 2019 · 1 comment · Fixed by #7155
Closed

Make a distinction between bundled third-parties and external third-party dependencies #7150

fmarier opened this issue Nov 28, 2019 · 1 comment · Fixed by #7155
Assignees
@fmarier
Labels
licensing priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.1.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Nov 28, 2019 •
edited
Loading

In order to avoid giving the impression that Brave is bundling some external components when they are in fact downloaded separately at run-time, we should make a distinction between bundled third-party dependencies and external components (like Brave Ad Block) which are separate from the browser.
@fmarier fmarier added priority/P1 A very extremely bad problem. We might push a hotfix for it. licensing labels Nov 28, 2019
@fmarier fmarier added this to the 1.1.x - Beta milestone Nov 28, 2019
@fmarier fmarier self-assigned this Nov 28, 2019
This was referenced Nov 29, 2019
Closed
Merged
fmarier added a commit that referenced this issue Nov 29, 2019
@fmarier
Automatically generate adblock component LICENSE
77c4892 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes #7150).
@fmarier fmarier mentioned this issue Nov 29, 2019
Merged
28 tasks
fmarier added a commit that referenced this issue Dec 2, 2019
@fmarier
Automatically generate adblock component LICENSE
cc54911 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes #7150).
@fmarier fmarier modified the milestones: 1.1.x - Beta, 1.3.x - Nightly Dec 3, 2019
fmarier added a commit that referenced this issue Dec 3, 2019
@fmarier
Automatically generate adblock component LICENSE
1e75e51 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes #7150).
fmarier added a commit that referenced this issue Dec 3, 2019
@fmarier
Automatically generate adblock component LICENSE
eacacd2 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes #7150).
fmarier added a commit that referenced this issue Dec 5, 2019
@fmarier
Automatically generate adblock component LICENSE
7fbd5f7 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes #7150).
fmarier added a commit that referenced this issue Dec 5, 2019
@fmarier
Automatically generate adblock component LICENSE
2fb64f8 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes #7150).
@kjozwiak kjozwiak modified the milestones: 1.3.x - Dev, 1.1.x - Release Dec 6, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2019 •
edited by btlechowski
Loading

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS macOS Version 10.15.1 (Build 19B88)

Verification passed on

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4103

image

Verification passed on

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Windows 7 Service Pack 1 (Build 7601.24530)

Verified test plan from brave/brave-core#4103

image

This was referenced Dec 9, 2019
Closed
Closed
@fmarier fmarier mentioned this issue Jan 7, 2020
Closed
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@fmarier
Automatically generate adblock component LICENSE
a841bb0 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes brave/brave-browser#7150).
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@fmarier
Automatically generate adblock component LICENSE
be9e650 
The generated LICENSE includes a preamble which clarifies that
these licenses apply to lists which are downloaded at run time and
are separate from the Brave Browser (fixes brave/brave-browser#7150).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
licensing priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging a pull request may close this issue.

Automatically generate LICENSE files for external components brave/brave-browser
3 participants
@fmarier @kjozwiak @btlechowski