Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve licensing of external components #4103

Merged
merged 9 commits into from
Dec 2, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 29, 2019

Fixes brave/brave-browser#7148 and brave/brave-browser#7150.

Submitter Checklist:

Test Plan:

The Easy List, Disconnect and HTTPS Everywhere entries should be gone from brave://credits. Instead, five new components should be present:

  • Brave Ad Block
  • Brave Ethereum Remote Client Extension
  • Brave HTTPS Everywhere
  • Brave Local Data
  • Brave Tor Client

Note:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

That license is used by several adblock lists.
…ist license

This is the license text as it appears on the EasyList website:

https://easylist.to/pages/licence.html
The LICENSE file of that component is generated as part of the
build process by lib/licensing.js in brave/brave-browser.
Clarify that Tor is a separate component that may be downloaded
by the Brave Browser.
Clarify that the HTTPS Everywhere license applies to a list that
is downloaded at run time and is separate from the Brave Browser.
This is related to an extension that is not downloaded until users
open the Crypto Wallets sections of brave://settings.
The LICENSE file of that component is generated as part of the
build process by lib/licensing.js in brave/brave-browser.
@fmarier fmarier added this to the 1.3.x - Nightly milestone Nov 29, 2019
@fmarier fmarier requested a review from bbondy November 29, 2019 07:17
@fmarier fmarier self-assigned this Nov 29, 2019
@fmarier
Copy link
Member Author

fmarier commented Nov 29, 2019

The diff is quite large, but hopefully the individual commits will be easier to review.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add is-abp license
2 participants