-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve licensing of external components #4103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That license is used by several adblock lists.
…ist license This is the license text as it appears on the EasyList website: https://easylist.to/pages/licence.html
The LICENSE file of that component is generated as part of the build process by lib/licensing.js in brave/brave-browser.
Clarify that Tor is a separate component that may be downloaded by the Brave Browser.
Clarify that the HTTPS Everywhere license applies to a list that is downloaded at run time and is separate from the Brave Browser.
This is related to an extension that is not downloaded until users open the Crypto Wallets sections of brave://settings.
The LICENSE file of that component is generated as part of the build process by lib/licensing.js in brave/brave-browser.
The diff is quite large, but hopefully the individual commits will be easier to review. |
28 tasks
bsclifton
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
This was referenced Dec 2, 2019
This was referenced Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#7148 and brave/brave-browser#7150.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
The Easy List, Disconnect and HTTPS Everywhere entries should be gone from
brave://credits
. Instead, five new components should be present:Note:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.