Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display glitch when OOP rasterization is enabled (default value) #6979

Closed
gingerlime opened this issue Nov 18, 2019 · 4 comments · Fixed by brave/brave-core#4318
Closed

Display glitch when OOP rasterization is enabled (default value) #6979

gingerlime opened this issue Nov 18, 2019 · 4 comments · Fixed by brave/brave-core#4318
Assignees
@bsclifton
Labels
gpu/driver QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include workaround/flags resolve by flipping brave://flags
Milestone
1.3.x - Release

Comments

@gingerlime
Copy link

gingerlime commented Nov 18, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#4318

Description

Weird display artifacts showing on some elements, moving around when moving the mouse. It happens on several websites / pages.

See animated gif on Github

brave display glitch

Screen Shot 2019-11-18 at 17 20 12

Steps to Reproduce

Just move the mouse around. But even without moving it, some "empty" spots are showing from time to time.

Actual result:

see gif

Expected result:

no glitches? :)

Reproduces how often:

Happens all the time since upgrading.

Brave version (brave://version info)

Version 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)

Other Additional Information:

Doesn't happen in other apps/browsers on the same computer (Macbook air 11" 2015, running High Sierra 10.13.6). Does not happen in Firefox, Safari or Chrome (Version 78.0.3904.97 (Official Build) (64-bit)).
@bsclifton
Copy link
Member

Thanks for reporting, @gingerlime! Can you please try opening this URL up and changing the value of the flag to Disabled?
brave://flags/#enable-oop-rasterization

If that doesn't fix things (you'll likely have to restart), then I would suspect this to be the issue:
#6506

@bsclifton bsclifton added gpu/driver needs-more-info The report requires more detail before we can decide what to do with this issue. labels Nov 18, 2019
@gingerlime
Copy link
Author

@bsclifton yep, disabling the flag seems to fix it. 👍 Thank you!

@bsclifton
Copy link
Member

bsclifton commented Nov 19, 2019 •
edited
Loading

Thanks for reporting back, @gingerlime! Glad this resolved the issue 😄

cc: @bbondy - as this deviates from Chromium and does cause a graphics glitch

@bsclifton bsclifton added workaround/flags resolve by flipping brave://flags and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Nov 19, 2019
@bsclifton bsclifton changed the title display glitch after upgrading Enabling OOP rasterization causes display glitch Nov 19, 2019
@bsclifton bsclifton changed the title Enabling OOP rasterization causes display glitch Display glitch when OOP rasterization is enabled (default value) Nov 19, 2019
@bsclifton bsclifton self-assigned this Jan 7, 2020
bsclifton added a commit to brave/brave-core that referenced this issue Jan 7, 2020
@bsclifton
OOP rasterization is causing issues for some users (artifacts, crashes)
8b58886 
Fixes brave/brave-browser#7581
Fixes brave/brave-browser#6979

Reverts #3793
@bsclifton bsclifton mentioned this issue Jan 7, 2020
Merged
32 tasks
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 7, 2020
@bsclifton bsclifton added the QA/No label Jan 9, 2020
This was referenced Jan 9, 2020
Merged
Merged
@btlechowski
Copy link

btlechowski commented Jan 14, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.3.90 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4318

image

Verified passed with

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-14 at 5 49 29 PM

Verification passed on

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@LaurenWags LaurenWags mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
gpu/driver QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include workaround/flags resolve by flipping brave://flags
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Default OOP rasterization to off (original value) brave/brave-core
5 participants
@gingerlime @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya