Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default OOP rasterization to off (original value) (uplift to 1.3.x) #4352

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Default OOP rasterization to off (original value) (uplift to 1.3.x) #4352

merged 1 commit into from
Jan 10, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 9, 2020 •
edited by kjozwiak
Loading

Uplift of #4318
Fixes brave/brave-browser#7581
Fixes brave/brave-browser#6979

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Jan 9, 2020
@brave-builds brave-builds added this to the 1.3.x - Beta milestone Jan 9, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv January 9, 2020 22:16
@kjozwiak
Copy link
Member

Restarting Linux due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4318_bsc-revert-oop-rasterization_1.3.x/1/execution/node/562/log/ failing. This particular failure is a known intermittent issue that's not related to this particular PR. However, because macOS needs to be restarted either way, I'll restart Linux as well.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4318_bsc-revert-oop-rasterization_1.3.x/1/execution/node/698/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows labels Jan 10, 2020
@kjozwiak
Copy link
Member

@bsclifton looks like both brave/brave-browser#7581 & brave/brave-browser#6979 are labeled as QA/No and there's no test case associated with #4318. Looks like this was wasn't checked on Nightly as per You have tested your change on Nightly. not being checked off.

Is there anything that we can do here re: QAing before we uplift these?

@bsclifton
Copy link
Member

@kjozwiak good question; I guess there is a QA step than can be done, now that I think of it 😄

Let me add that in...

@bsclifton
Copy link
Member

Added steps to #4318 and marked both as QA/Yes

Will check Nightly here in a few mins and update the checkbox

@bsclifton
Copy link
Member

Verified on Nightly v1.5.24 👍 Ready for uplift consideration

kjozwiak
kjozwiak approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors after a few restarts. Both @bsclifton and QA have gone through the issue and verified it's working as expected as per #4318 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit a98ef6d into 1.3.x Jan 10, 2020
@kjozwiak kjozwiak deleted the pr4318_bsc-revert-oop-rasterization_1.3.x branch January 10, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases