Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copy to clarify that Verifying wallet is an optional task #7102

Closed
jenn-rhim opened this issue Nov 26, 2019 · 1 comment · Fixed by brave/brave-core#4099
Closed

Change copy to clarify that Verifying wallet is an optional task #7102

jenn-rhim opened this issue Nov 26, 2019 · 1 comment · Fixed by brave/brave-core#4099

Comments

@jenn-rhim
Copy link

Description

Please change the wording in the dialog below. @NejcZdovc

dialog-verify-3

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc NejcZdovc added the needs-text-change This change requires some careful wording. label Nov 26, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 28, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 28, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 28, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jan 7, 2020

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified test plan from Updates copy for verify modal brave-core#4099
  • Verified when accessing the wallet modal from Verify Wallet button, Add Funds, Withdraw Funds, and verify links on brave://rewards
  • Verified when accessing the wallet modal from Verify Wallet button and Add Funds from BR panel

Screen Shot 2020-01-07 at 10 41 07 AM

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from Updates copy for verify modal brave-core#4099
  • Verified when accessing the wallet modal from Verify Wallet button, Add Funds, Withdraw Funds, and verify links on brave://rewards
  • Verified when accessing the wallet modal from Verify Wallet button and Add Funds from BR panel
    image

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS
  • Verified test plan from Updates copy for verify modal brave-core#4099
  • Verified when accessing the wallet modal from Verify Wallet button, Add Funds, Withdraw Funds, and verify links on brave://rewards
  • Verified when accessing the wallet modal from Verify Wallet button and Add Funds from BR panel

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants