Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates copy for verify modal #4099

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Updates copy for verify modal #4099

merged 1 commit into from
Nov 28, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 28, 2019

Resolves brave/brave-browser#7102

Submitter Checklist:

Test Plan:

  • enable rewards
  • click on verify wallet
  • make sure that modal text matches text in the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 28, 2019
@NejcZdovc NejcZdovc requested a review from a team November 28, 2019 08:39
@NejcZdovc NejcZdovc self-assigned this Nov 28, 2019
@NejcZdovc NejcZdovc marked this pull request as ready for review November 28, 2019 09:54
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@NejcZdovc
Copy link
Contributor Author

CI failed on test-install. Not related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change copy to clarify that Verifying wallet is an optional task
2 participants