Linux shows wrong version installed and wrong browser icon #712

srirambv · 2018-08-09T12:18:59Z

Description

Linux shows wrong version installed and wrong browser icon

Steps to Reproduce

Manually install 0.53.1 via dpkg -i <0.53.1.deb>
Download 0.53.2 deb file. Install it via Ubuntu Software package manager
Software Package manager still shows 0.53.1 and shows Orange browser icon
Launch browser, About Brave shows 0.53.2 which is the correct version
Note: The wrong browser icon shows up on all versions, not specific to update scenario mentioned above

Actual result:

Expected result:

Should show correct version in package manager and should install correct browser icon

Reproduces how often:

100%

Brave version (about:brave info)

0.53.1 and 0.53.2

Reproducible on current release:

No browser-laptop shows correct version when installed and shows the correct browser icon

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bbondy marked the issue as blocker since its version mismatch. Please move to backlog if needed

The text was updated successfully, but these errors were encountered:

mbacchi · 2018-08-20T19:34:22Z

After looking at this a little bit, I think we need to allow for dev/beta specific icons in the script chrome/installer/linux/common/installer.include just as Chrome does in this section:

https://github.com/chromium/chromium/blob/master/chrome/installer/linux/common/installer.include#L278-L284

They obviously have different icons for dev/beta and we should provide for this to integrate with the desktop. I will work on a patch soon.

mbacchi · 2018-08-27T20:44:35Z

So this isn't as simple as I thought. I'm unsure how chromium produces dev/beta icons in their build, because they aren't in the repository. @simonhong do you have any ideas how we can mimic what they do for browser icons with dev/beta?

I see that in their packages they have differing icons depending on the channel:

[mbacchi@host Downloads]$ ls -ltr /opt/google/chrome-beta/*.png
-rw-r--r--. 1 root root  2514 Aug 22 23:03 /opt/google/chrome-beta/product_logo_64_beta.png
-rw-r--r--. 1 root root  1852 Aug 22 23:03 /opt/google/chrome-beta/product_logo_48_beta.png
-rw-r--r--. 1 root root  1194 Aug 22 23:03 /opt/google/chrome-beta/product_logo_32_beta.png
-rw-r--r--. 1 root root 11126 Aug 22 23:03 /opt/google/chrome-beta/product_logo_256_beta.png
-rw-r--r--. 1 root root   900 Aug 22 23:03 /opt/google/chrome-beta/product_logo_24_beta.png
-rw-r--r--. 1 root root   818 Aug 22 23:03 /opt/google/chrome-beta/product_logo_22_beta.png
-rw-r--r--. 1 root root   682 Aug 22 23:03 /opt/google/chrome-beta/product_logo_16_beta.png
-rw-r--r--. 1 root root  5295 Aug 22 23:03 /opt/google/chrome-beta/product_logo_128_beta.png
[mbacchi@host Downloads]$ ls -ltr /opt/google/chrome/*.png
-rw-r--r--. 1 root root  2786 Aug  7 20:20 /opt/google/chrome/product_logo_64.png
-rw-r--r--. 1 root root  2047 Aug  7 20:20 /opt/google/chrome/product_logo_48.png
-rw-r--r--. 1 root root  1289 Aug  7 20:20 /opt/google/chrome/product_logo_32.png
-rw-r--r--. 1 root root 13480 Aug  7 20:20 /opt/google/chrome/product_logo_256.png
-rw-r--r--. 1 root root   962 Aug  7 20:20 /opt/google/chrome/product_logo_24.png
-rw-r--r--. 1 root root   870 Aug  7 20:20 /opt/google/chrome/product_logo_22.png
-rw-r--r--. 1 root root   689 Aug  7 20:20 /opt/google/chrome/product_logo_16.png
-rw-r--r--. 1 root root  6184 Aug  7 20:20 /opt/google/chrome/product_logo_128.png

But in their source they don't have files with dev or beta in their name:

[mbacchi@host chromium]$ pwd
~/data/repos/chromium
[mbacchi@host chromium]$ find . -name product_logo*.png
./extensions/test/data/unpacker/good_package/product_logo_128.png
./extensions/test/data/unpacker/bad_zip/product_logo_128.png
./remoting/resources/product_logo_32.png
./components/resources/default_200_percent/chromium/product_logo.png
./components/resources/default_100_percent/chromium/product_logo.png
./chrome/android/java/res_chromium/drawable-xxhdpi/product_logo_name.png
./chrome/android/java/res_chromium/drawable-xhdpi/product_logo_name.png
./chrome/android/java/res_chromium/drawable-hdpi/product_logo_name.png
./chrome/android/java/res_chromium/drawable-mdpi/product_logo_name.png
./chrome/android/java/res_chromium/drawable-xxxhdpi/product_logo_name.png
./chrome/app/theme/chromium/product_logo_24.png
./chrome/app/theme/chromium/product_logo_22.png
./chrome/app/theme/chromium/product_logo_22_mono.png
./chrome/app/theme/chromium/product_logo_48.png
./chrome/app/theme/chromium/product_logo_128.png
./chrome/app/theme/chromium/product_logo_64.png
./chrome/app/theme/chromium/product_logo_256.png
./chrome/app/theme/default_200_percent/chromium/product_logo_16.png
./chrome/app/theme/default_200_percent/chromium/product_logo_name_22.png
./chrome/app/theme/default_200_percent/chromium/product_logo_name_48.png
./chrome/app/theme/default_200_percent/chromium/product_logo_32.png
./chrome/app/theme/default_200_percent/chromium/product_logo_white.png
./chrome/app/theme/default_100_percent/chromium/product_logo_16.png
./chrome/app/theme/default_100_percent/chromium/product_logo_name_22.png
./chrome/app/theme/default_100_percent/chromium/product_logo_name_48.png
./chrome/app/theme/default_100_percent/chromium/product_logo_32.png
./chrome/app/theme/default_100_percent/chromium/product_logo_white.png

If you can give me input on how the grd files (app/theme/brave_theme_resources.grd) work regarding the icons I'd appreciate it.

simonhong · 2018-08-28T00:24:28Z

FYI, windows icons in linux are handled by below in brave_views_delegate_linux.cc.

int GetWindowIconResourceId() {
#if defined(OFFICIAL_BUILD)
  switch (chrome::GetChannel()) {
    case version_info::Channel::DEV:
      return IDR_PRODUCT_LOGO_128_DEV;
    case version_info::Channel::BETA:
      return IDR_PRODUCT_LOGO_128_BETA;
    case version_info::Channel::CANARY:
      return IDR_PRODUCT_LOGO_128_NIGHTLY;
    default:
      return IDR_PRODUCT_LOGO_128;
  }
#else
  return IDR_PRODUCT_LOGO_128_DEVELOPMENT;
#endif
}

The resources are defined in brave_unscaled_resources.grd.
However, I assume that icon in package file uses different method(not sure).
I'll also try to find how icon is involved in packaging.

simonhong · 2018-08-28T01:32:14Z

I think we should add more resources like is_chrome_branded

copy("theme_files") {
  visibility = [ ":*" ]
  sources = [
    "$branding_dir/BRANDING",
    "$branding_dir/linux/product_logo_32.xpm",
    "$branding_dir/product_logo_128.png",
    "$branding_dir/product_logo_22.png",
    "$branding_dir/product_logo_24.png",
    "$branding_dir/product_logo_256.png",
    "$branding_dir/product_logo_48.png",
    "$branding_dir/product_logo_64.png",
    "$branding_dir_100/product_logo_16.png",
    "$branding_dir_100/product_logo_32.png",
  ]
  if (is_chrome_branded) {
    sources += [
      "$branding_dir/linux/product_logo_32_beta.xpm",
      "$branding_dir/linux/product_logo_32_dev.xpm",
      "$branding_dir/product_logo_128_beta.png",
      "$branding_dir/product_logo_128_dev.png",
      "$branding_dir/product_logo_22_beta.png",
      "$branding_dir/product_logo_22_dev.png",
      "$branding_dir/product_logo_24_beta.png",
      "$branding_dir/product_logo_24_dev.png",
      "$branding_dir/product_logo_256_beta.png",
      "$branding_dir/product_logo_256_dev.png",
      "$branding_dir/product_logo_48_beta.png",
      "$branding_dir/product_logo_48_dev.png",
      "$branding_dir/product_logo_64_beta.png",
      "$branding_dir/product_logo_64_dev.png",
      "$branding_dir_100/product_logo_16_beta.png",
      "$branding_dir_100/product_logo_16_dev.png",
      "$branding_dir_100/product_logo_32_beta.png",
      "$branding_dir_100/product_logo_32_dev.png",
    ]
  }
  outputs = [
    "$root_out_dir/installer/theme/{{source_file_part}}",
  ]
}

In chromium project, I think chrome team does not include google_chrome brand resources in chrome/app/theme/google_chrome folder. Because of that, I think we can't see above files in is_chrome_branded.

I think we should add more resources for linux like is_chrome_branded did.

srirambv · 2018-08-28T19:04:46Z

this is also showing shown on app launcher and here

mbacchi · 2018-08-28T19:36:59Z

Thanks for that input @simonhong. Since we only have one dev/beta branded png image, I will configure the build to include that for now, but we should open another issue to create the full complement of dev/beta images. There are a number of uses for the various sizes of png images, and without all of them we are not providing the full experience that chrome has.

If I change the build scripts to include both the standard png images and the dev/beta png images, the dev channel build behavior still shows as above, with the normal color product logo when launching the browser. If I instead only include the dev/beta product logo it properly shows the blue dev channel product logo. But this is the only logo included in that dev/beta build and I would expect we need other logo sizes for other images.

For now this single image works in my testing.

When building dev/beta channel on Linux, the release png images were being packaged even though the alternate color images should have been present in the package. This corrects that behavior. Fixes brave/brave-browser#712

srirambv · 2018-09-21T14:59:29Z

Verification Passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

srirambv added bug release/blocking OS/Linux setup/installer labels Aug 9, 2018

srirambv added this to the Releasable builds milestone Aug 9, 2018

bbondy assigned mbacchi Aug 10, 2018

mbacchi added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Aug 20, 2018

mbacchi mentioned this issue Aug 28, 2018

Copy and package dev/beta channel png images brave/brave-core#366

Closed

11 tasks

mbacchi mentioned this issue Aug 29, 2018

Copy and package dev/beta channel png images brave/brave-core#371

Merged

11 tasks

mbacchi closed this as completed in brave/brave-core#371 Aug 29, 2018

bbondy added the QA/Yes label Sep 10, 2018

srirambv mentioned this issue Sep 21, 2018

Ubuntu shows wrong image in app search but uses correct icon when browser is launched #1237

Closed

srirambv added QA Pass-Linux and removed QA/Yes labels Sep 21, 2018

bbondy added the QA/Yes label Sep 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux shows wrong version installed and wrong browser icon #712

Linux shows wrong version installed and wrong browser icon #712

srirambv commented Aug 9, 2018

mbacchi commented Aug 20, 2018

mbacchi commented Aug 27, 2018

simonhong commented Aug 28, 2018

simonhong commented Aug 28, 2018

srirambv commented Aug 28, 2018

mbacchi commented Aug 28, 2018

srirambv commented Sep 21, 2018

Linux shows wrong version installed and wrong browser icon #712

Linux shows wrong version installed and wrong browser icon #712

Comments

srirambv commented Aug 9, 2018

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (about:brave info)

Reproducible on current release:

Website problems only:

Additional Information

mbacchi commented Aug 20, 2018

mbacchi commented Aug 27, 2018

simonhong commented Aug 28, 2018

simonhong commented Aug 28, 2018

srirambv commented Aug 28, 2018

mbacchi commented Aug 28, 2018

srirambv commented Sep 21, 2018