Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy and package dev/beta channel png images #371

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Aug 29, 2018

When building dev/beta channel on Linux, the release
png images were being packaged even though the
alternate color images should have been present in
the package. This corrects that behavior.

Fixes brave/brave-browser#712

Replaces PR #366

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

When building dev/beta channel on Linux, the release
png images were being packaged even though the
alternate color images should have been present in
the package. This corrects that behavior.

Fixes brave/brave-browser#712
@mbacchi mbacchi self-assigned this Aug 29, 2018
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbacchi mbacchi merged commit 32b930b into master Aug 29, 2018
@mbacchi mbacchi deleted the issue712-try2 branch August 29, 2018 16:02
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Introduce --touch_overridden_files option to build command
petemill pushed a commit that referenced this pull request Jul 27, 2020
Introduce --touch_overridden_files option to build command
petemill pushed a commit that referenced this pull request Jul 28, 2020
Introduce --touch_overridden_files option to build command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux shows wrong version installed and wrong browser icon
2 participants