Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #6684 - Alignment issue for Token grants claimed in BR panel #7198

Closed
btlechowski opened this issue Dec 3, 2019 · 3 comments · Fixed by brave/brave-core#4134

Comments

@btlechowski
Copy link

With #6684 English locale was fixed. But there are still locales that the issue reproduces

Steps to Reproduce

Test case 1

  1. Launch Brave in German locale on staging
  2. Enable rewards
  3. Claim grant

Test case 2

  1. Launch Brave in German locale on staging
  2. Enable rewards and claim grants
  3. Add few verified sites to a-c table
  4. Send one-time tip and monthly tip to a verified pubs
  5. Wait for auto contribution to complete

Actual result:

Token grants claimed is misaligned
image

Expected result:

Like in English locale
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.3.50 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

@NejcZdovc @ryanml @brave/legacy_qa @rebron

@NejcZdovc
Copy link
Contributor

I think what we should do is reduce line-height so that it looks nice even in two rows as we can't handle all languages in one line

@LaurenWags
Copy link
Member

Can also use Portuguese to verify this issue per #6684 (comment)

@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2020

Verified passed with

Brave 1.4.82 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified TC1 and 2 from description:

Bildschirmfoto 2020-02-11 um 11 01 51 AM

Bildschirmfoto 2020-02-11 um 11 09 03 AM

Verification passed on

rave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment