Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #6684 - Alignment issue for Token grants claimed in BR panel #4134

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

masparrow
Copy link
Contributor

@masparrow masparrow commented Dec 4, 2019

Resolves brave/brave-browser#7198

Submitter Checklist:

Test Plan:

As per brave/brave-browser#7198

Although this is a test string, the line height has been tightened up as follows;

Screenshot 2019-12-06 at 10 01 10

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@masparrow masparrow self-assigned this Dec 4, 2019
@masparrow masparrow requested a review from a team December 4, 2019 19:56
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need to keep the same design, meaning that we now need to add spacing around ListToken to preserve old design.

Expected spacing:
image

@masparrow
Copy link
Contributor Author

@NejcZdovc Updated with padding as per change request - using 10px top/bottom;

Screenshot 2019-12-05 at 10 09 19

@NejcZdovc
Copy link
Contributor

CI failed on macos (unrelated), but this change is only CSS so merging

@NejcZdovc NejcZdovc merged commit 8e48e61 into master Dec 9, 2019
@NejcZdovc NejcZdovc deleted the issues/7198 branch December 9, 2019 07:41
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up to #6684 - Alignment issue for Token grants claimed in BR panel
2 participants