Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id with auto increment to pending contribution #7275

Closed
NejcZdovc opened this issue Dec 9, 2019 · 1 comment · Fixed by brave/brave-core#4177
Closed

Add id with auto increment to pending contribution #7275

NejcZdovc opened this issue Dec 9, 2019 · 1 comment · Fixed by brave/brave-core#4177

Comments

@NejcZdovc
Copy link
Contributor

We should add id in pending contribution table. This way we don't need to send 3 params to determinate which one is which. It's also less error prone as in theory we could have record with the same 3 keys, meaning we would be deleting too much data.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 13, 2020

Verification passed on

Brave 1.4.86 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.4.91 Chromium: 80.0.3987.116 (Official Build) beta (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from Adds id to pending contributions table brave-core#4177 for a clean profile
    • Verified for both one time and recurring (monthly) tips
    • Verified both display in pending contributions table in UI
    • Verified both display in pending_contribution table in DB
    • Verified both types can be deleted from table in UI

14x pend_contrib DB table

  • Verified test plan from Adds id to pending contributions table brave-core#4177 for a profile upgraded from 1.3.118
    • Verified for both one time and recurring (monthly) tips
    • Verified both display in pending contributions table in UI
    • Verified both display in pending_contribution table in DB
    • Verified both types can be deleted from table in UI

1.3.x:
13x

1.4.x:
14x

Verification passed on

Brave 1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Linux
  • Verified test plan from Adds id to pending contributions table brave-core#4177 for a clean profile
    Verified for both one time and recurring (monthly) tips
    Verified both displays in pending contributions table in UI
    Verified both displays in pending_contribution table in DB
    Verified both types can be deleted from table in UI

image
image

  • Verified test plan from Adds id to pending contributions table brave-core#4177 for a profile upgraded from 1.3.118
    • Verified for both one time and recurring (monthly) tips
    • Verified both displays in pending contributions table in UI
    • Verified both displays in pending_contribution table in DB
    • Verified both types can be deleted from the table in UI

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment