Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP SI - no images shown when both NTP SI flags enabled #7930

Closed
LaurenWags opened this issue Jan 27, 2020 · 4 comments · Fixed by brave/brave-core#4446
Closed

NTP SI - no images shown when both NTP SI flags enabled #7930

LaurenWags opened this issue Jan 27, 2020 · 4 comments · Fixed by brave/brave-core#4446
Assignees
@petemill @simonhong
Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.3.x - Release

Comments

@LaurenWags
Copy link
Member

Description

Found while testing brave/brave-core#4075

Test plan 2 from above PR fails, images are not shown when both flags are enabled.

Steps to Reproduce

2. With the feature flag and demo feature flag, demo sponsored content is shown

  1. Fresh or previous profile
  2. Visit chrome://flags and turn on both above feature flags
  3. Relaunch browser
  4. Refresh NTP until sponsored background is shown. Internal demo sponsored background is the "Technikke" background with NO green lines.

When retesting, retest on both clean and upgrade profiles.

Actual result:

blank background with Technikke logo
Screen Shot 2020-01-27 at 8 50 12 AM

Expected result:

Technikke images without green lines

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @petemill
@btlechowski
Copy link

btlechowski commented Jan 27, 2020 •
edited
Loading

Reproduced on Windows 7 and 10

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1909 (Build 18363.592)

image

@petemill petemill self-assigned this Jan 27, 2020
@simonhong simonhong self-assigned this Jan 28, 2020
@simonhong simonhong added this to the 1.5.x - Nightly milestone Jan 28, 2020
simonhong added a commit to brave/brave-core that referenced this issue Jan 28, 2020
@simonhong
Change branded wallpaper demo resource file name
6d8aa46 
Wallpaper resource name should follow NTPSponsoredImagesData naming
rule. NTPSponsoredImagesData renerates path like wallpaper-N.jpg.
So, resource name also should be XXX/wallpaper-N.jpg.

fix brave/brave-browser#7930
@simonhong simonhong mentioned this issue Jan 28, 2020
Merged
32 tasks
@LaurenWags LaurenWags mentioned this issue Jan 28, 2020
Merged
@GeetaSarvadnya
Copy link

Reproduced in windows 10 x64

Brave 1.5.63 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 28, 2020 •
edited
Loading

Reproduced on Linux Mint

Brave 1.5.63 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Linux

@rebron rebron changed the title no images shown when both SNTP flags enabled NTP SI - no images shown when both NTP SI flags enabled Jan 29, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 31, 2020 •
edited by kjozwiak
Loading

Verification passed on

Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR mentioned in the description
  • Verified on both clean and upgraded profile
    Clean profile>Turn on both flags>NTP-SI is shown
    image
    Clean profile>Enable rewards>Disable Ads>Turn on both flags>NTP-SI is shown
    image
    Clean profile>Enable rewards>Disable rewards>Turn on both flags>NTP-SI is shown
    image
    Clean profile>Enable Rewards>Disable Ads>Disable Rewards widget>Turn on both flags>NTP-SI is shown
    image

Verification passed on

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
  • Verified the STR mentioned in the description
  • Verified on both clean and upgraded profile
    Clean profile>Turn on both flags>NTP-SI is shown
    image
    Clean profile>Enable rewards>Disable Ads>Turn on both flags>NTP-SI is shown
    image
    Clean profile>Enable rewards>Disable rewards>Turn on both flags>NTP-SI is shown
    image
    Clean profile>Enable Rewards>Disable Ads>Disable Rewards widget>Turn on both flags>NTP-SI is shown
    image

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.15.3 (Build 19D76)

Clean profile -> Turn on both flags -> NTP SI being displayed

Screen Shot 2020-02-04 at 10 53 20 AM

Clean profile - > Enable rewards -> Disable Ads -> Turn on both flags -> NTP SI being displayed

Screen Shot 2020-02-04 at 10 54 54 AM

Clean profile -> Enable rewards -> Disable rewards -> Turn on both flags -> NTP SI being displayed

Screen Shot 2020-02-04 at 10 57 00 AM

Clean profile -> Enable Rewards -> Disable Ads -> Disable Rewards widget -> Turn on both flags -> NTP SI is being displayed

Screen Shot 2020-02-04 at 10 58 10 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

@simonhong simonhong

Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Change branded wallpaper demo resource file name brave/brave-core
6 participants
@petemill @kjozwiak @simonhong @LaurenWags @btlechowski @GeetaSarvadnya