Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change branded wallpaper demo resource file name #4446

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 28, 2020

Wallpaper resource name should follow NTPSponsoredImagesData naming
rule. NTPSponsoredImagesData renerates path like wallpaper-N.jpg.
So, resource name also should be XXX/wallpaper-N.jpg.

fix brave/brave-browser#7930

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Wallpaper resource name should follow NTPSponsoredImagesData naming
rule. NTPSponsoredImagesData renerates path like wallpaper-N.jpg.
So, resource name also should be XXX/wallpaper-N.jpg.

fix brave/brave-browser#7930
@simonhong simonhong added this to the 1.5.x - Nightly milestone Jan 28, 2020
@simonhong simonhong self-assigned this Jan 28, 2020
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes it 👍

@petemill petemill merged commit f4bff31 into master Jan 28, 2020
@petemill petemill deleted the simon-snpt-issue-7930 branch January 28, 2020 00:56
petemill added a commit that referenced this pull request Jan 29, 2020
Change branded wallpaper demo resource file name
This was referenced Jan 29, 2020
petemill added a commit that referenced this pull request Jan 29, 2020
Change branded wallpaper demo resource file name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTP SI - no images shown when both NTP SI flags enabled
2 participants