Uplift NTP SI to 1.4.x #4461
Merged
Uplift NTP SI to 1.4.x #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Tab Page Branded Wallpapers (desktop)
NTP Sponsored Images: Fix crash when using component with no data
Store components data with unique folder
New Tab Page WebUI: Rewards widget does not display Ads item if non-ads region
Change branded wallpaper demo resource file name
New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off
NTP Sponsored Images schemaVersion support
New Tab Page WebUI: Make sure footer is bottom aligned at all screen sizes
New Tab Page WebUI: automatically dismiss branded wallpaper notifications…
|
Looks like |
kjozwiak
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. macOS failed due to test-install as per #4461 (comment) but it's a known issue that's not specific to this particular PR. All the other platforms passed without any issues.
Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplifts the following PRs:
"Turn on {Brave Rewards | Brave Ads}"stringschemaVersioncheck