-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab Page WebUI: automatically dismiss branded wallpaper notifications… #4457
Conversation
9c8e486
to
ab391ad
Compare
…ions after page has been viewed for 4 seconds
ab391ad
to
344f230
Compare
* Waits until the viewport has been in view for a certain number of seconds | ||
* continuously before calling a provided function. | ||
*/ | ||
export default class VisibilityTimer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice snippet of code here 😄👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work here! Verified the test plan (including 4 seconds required view time). Code changes look good. In a perfect world, it would be amazing to have a browser test for this (or the branded NTP in general). If you think that might be doable (in the future of course!), could you file an issue with the requirements for a test?
CI passed (all green!) - going to merge so we can get this into the next Nightly 😄 |
New Tab Page WebUI: automatically dismiss branded wallpaper notifications…
New Tab Page WebUI: automatically dismiss branded wallpaper notifications…
… after page has been viewed for 4 seconds
Fix brave/brave-browser#7945
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.