Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page WebUI: Make sure footer is bottom aligned at all screen sizes #4454

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

petemill
Copy link
Member

@petemill petemill commented Jan 28, 2020

  • Footer now takes up all remaining space when Grid is in Flex mode (narrow viewport)
    • Achieved by adding a wrapper element so that the outer element can have flex: 1 and the inner-element can still vertically center the credits against the navigation.
  • Footer's Branded Logo margin is reduced to align most logo content which has transparency (at request of Design)
    • Achieved by overriding some margin on GridItemBrandedLogo. I didn't want to instead add margin to PhotoName since it's better to keep all grid-related spacing on the grid items.

Fix brave/brave-browser#7937

Test plan

On brave/brave-browser#7937 (turn off all widgets when viewport width < 870px).

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 29, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄👍

…sizes

- Footer now takes up all remaining space when Grid is in Flex mode (narrow viewport)
- Footer's Branded Logo margin is reduced to align most logo content which has transparency (at request of Design)
@bsclifton
Copy link
Member

Pushed a rebase so we can get a clean CI run 👍

@bsclifton bsclifton merged commit bdeaf2c into master Jan 29, 2020
@bsclifton bsclifton deleted the ntp-sbw-footer-alignment branch January 29, 2020 16:22
petemill pushed a commit that referenced this pull request Jan 29, 2020
New Tab Page WebUI: Make sure footer is bottom aligned at all screen sizes
This was referenced Jan 29, 2020
petemill pushed a commit that referenced this pull request Jan 29, 2020
New Tab Page WebUI: Make sure footer is bottom aligned at all screen sizes
petemill pushed a commit that referenced this pull request Jul 27, 2020
don't default to arm (x86/x64 builds are better for the emulator)
petemill pushed a commit that referenced this pull request Jul 28, 2020
don't default to arm (x86/x64 builds are better for the emulator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footer moves to top of NTP if all widgets turned off
3 participants