Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP SI - ads item in NTP rewards widget is shown for unsupported ads region message #7944

Closed
btlechowski opened this issue Jan 27, 2020 · 3 comments · Fixed by brave/brave-core#4445

Comments

@btlechowski
Copy link

btlechowski commented Jan 27, 2020

It looks like ads item: Sorry! Ads are not yet available in your region. and Estimated earnings so far this month are shown in NTP rewards widget

This is a regression

Steps to Reproduce

  1. Open Brave in Unsupported region (used Luxemburg)
  2. Enable flag for SNTP
  3. Restart
  4. Open new tab until you see a SNTP is shown

Actual result:

Ads item is shown.
Sorry! Ads are not yet available in your region. and Estimated earnings so far this month are shown
image

Expected result:

Ads item is not shown
image

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1909 (Build 18363.592)

cc @brave/legacy_qa @petemill @rebron

@rebron
Copy link
Collaborator

rebron commented Jan 27, 2020

cc: @bradleyrichter

@LaurenWags
Copy link
Member

Reproduces on macOS

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

@petemill petemill self-assigned this Jan 28, 2020
@btlechowski btlechowski changed the title SNTP - Fix font style for unsupported ads region message SNTP - ads item in NTP rewards widget is shown for unsupported ads region message Jan 28, 2020
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 28, 2020
@rebron rebron changed the title SNTP - ads item in NTP rewards widget is shown for unsupported ads region message NTP SI - ads item in NTP rewards widget is shown for unsupported ads region message Jan 29, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 31, 2020

Verification passed on

Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
  • Verified on both clean and upgraded profile

image

Verification passed on

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
  • Verified on both clean and upgraded profile

image

Verification PASSED on macOS 10.15.3 using the following build:

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.15.3 (Build 19D76)

Screenshot 2020-02-03 at 18 12 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment