crash after updating to 1.3.x

[LaurenWags]

Description

Multiple reports of crashing after updating to 1.3.x, unable to keep Brave open:
https://twitter.com/brave/status/1225842308014170112
https://twitter.com/brave/status/1225842071900020741
https://twitter.com/brave/status/1225841791569580034

Steps to Reproduce

Unsure, possibly related to sync

Actual result:

see below tweet for video of issue
https://twitter.com/bpemble/status/1225838160162115586

Expected result:

No crash

Reproduces how often:

easily for affected users, not all users affected

Brave version (brave://version info)

1.1.113

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? unsure
• Can you reproduce this issue with the dev channel? unsure
• Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @jsecretan @darkdh

[CharlieRanalli]

Crash report attached if it helps, sync enabled, same behavior as other affected users on Twitter.

Suggested script produced this:
cr-mac-03:~ charlieranalli$ /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --disable-brave-sync
[0207/142113.418995:WARNING:process_memory_mac.cc(93)] mach_vm_read(0x7ffeef8fb000, 0x2000): (os/kern) invalid address (1)
[0207/142113.604945:WARNING:system_snapshot_mac.cc(42)] sysctlbyname kern.nx: No such file or directory (2)
[1335:775:0207/142114.269484:ERROR:child_thread_impl.cc(222)] Invalid PlatformChannel receive right
Segmentation fault: 11

69C290D3-D551-EF20-0168-01D6DDC43F66.txt

[kevinp2]

Same issue here. I have now become dependent upon Brave, and this happened right after the mandatory upgrade. Please help!

[LaurenWags]

@kevinp2 the team is actively working on a fix. However, some users have reported that if Brave stays open for a minute or two, they are able to do the following to stop the crashing:

1. Navigate to brave://sync
2. Disable bookmark sync from this page

Unfortunately if Brave crashes immediately this won't work for you. The team is working on a fix.

[kevinp2]

Hi, an update: I reinstalled Brave from brave.com Brave now opens properly and I have my bookmarks back. Phew!

However, I lost my two open windows and tabs which ironically I had just spent time rearranging and organizing. Is there any way to get them back?

[jonathansampson]

@kevinp2 Do you now see sponsored new tab pages (every fourth new tab opened)?

[kevinp2]

@kevinp2 Do you now see sponsored new tab pages (every fourth new tab opened)?

Hi @jonathansampson , not sure what you mean. I have my history back, but not the two windows and about 20 tabs I had open between them.

[jonathansampson]

@kevinp2 Apologies for the confusion. This version of Brave shipped a New Tab Page update, which allows users to earn BAT from the imagery shown on every 4th new tab. If you open a few new tabs, do you eventually see a custom background for Western Digital?

[CharlieRanalli]

Reinstalling also worked for me - likely because it reverted to 1.2.43

[jonathansampson]

@CharlieRanalli Great point. We did revert to 1.2.43 on brave.com.

[kevinp2]

@kevinp2 Apologies for the confusion. This version of Brave shipped a New Tab Page update, which allows users to earn BAT from the imagery shown on every 4th new tab. If you open a few new tabs, do you eventually see a custom background for Western Digital?

No, I opened a few tabs by right-clicking but did not see any tab with an ad.

[CharlieRanalli]

@CharlieRanalli Great point. We did revert to 1.2.43 on brave.com.

@jonathansampson Custom backgrounds should therefore be gone. I didn't get one after serially opening 6-7 new tabs but I wasn't sure if it was because i'm currently out of the country - I don't get ads here either

[jonathansampson]

@CharlieRanalli If you're on 1.2.43 (previous working build), you definitely won't be seeing the updated new tab pages. Regarding the lost windows, it sounds as though reverting to 1.2.43 may have overwritten some of the browser state. Unfortunately, I don't think those will be recoverable. My sincerest apologies for the inconvenience. We're working to resolve the issue promptly.

[smadgerano]

So, for those of us who don't want to revert back to a previous version because it means losing the current session (30+ tabs), my browsing history (which I use on a daily basis), and all my extension data that I have no idea how to transfer and isn't based in the cloud, what do we do? I deliberately chose the stable channel specifically so stuff like this didn't happen. The whole world would be up in arms if this was any of the other major browsers.

[jonathansampson]

We have a build now that should address this issue:

• Win x64 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup.exe
• Win x86 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup32.exe
• macOS - https://github.com/brave/brave-browser/releases/download/v1.3.114/Brave-Browser.dmg
• Linux - https://github.com/brave/brave-browser/releases/download/v1.3.114/brave-browser_1.3.114_amd64.deb

[mjgiarlo]

We have a build now that should address this issue:

• Win x64 - v1.3.114 BraveBrowserStandaloneSetup.exe (download)
• Win x86 - v1.3.114 BraveBrowserStandaloneSetup32.exe (download)
• macOS - v1.3.114 Brave-Browser.dmg (download)
• Linux - v1.3.114 brave-browser_1.3.114_amd64.deb (download)

Tested on Ubuntu 18.04 and worked like a charm. Thanks much, @jonathansampson & crew!

[louistiti]

We have a build now that should address this issue:

• Win x64 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup.exe
• Win x86 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup32.exe
• macOS - https://github.com/brave/brave-browser/releases/download/v1.3.114/Brave-Browser.dmg
• Linux - https://github.com/brave/brave-browser/releases/download/v1.3.114/brave-browser_1.3.114_amd64.deb

Tested on macOS Catalina and it's working now. Thanks to the team!

[martinib77]

We have a build now that should address this issue:

* Win x64 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup.exe

* Win x86 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup32.exe

* macOS - https://github.com/brave/brave-browser/releases/download/v1.3.114/Brave-Browser.dmg

* Linux - https://github.com/brave/brave-browser/releases/download/v1.3.114/brave-browser_1.3.114_amd64.deb

Tested on Windows 10 Enterprise N 2016 LTSB 64 bits.
It's Working. Thanks!

[aemxn]

I was having this issue today. No chance to get any report on the crash nor disabling sync in the settings as it happened fast. Installing v1.3.114 (64bit) link above works for me.

[cagrimertbakirci]

Same problem here. Currently testing turning off sync to see if it helps any. Will report results in a bit. It crashes every 4-5 minutes of use in my case.

Update: After 1 hour, I had no crashes after turning off sync.

[smadgerano]

So will installing the new version wipe out any local settings, local extension caches, and local wallet balance?

Edit: for anybody else looking I got fed up of waiting, go to uninstall Brave but you will get a tick box option to delete user data. I left this blank and then reinstalled, it worked OK

[robincsamuel]

I was facing the same issue, was crashing in a second. I tried the new build, but crashes in a few minutes.

I see this in the OSX console.

fault 12:23:29.924971+0530 Brave Browser Helper (GPU) Failed to get Metal shader cache main folder: failed to lookup DARWIN_USER_CACHE_DIR err:5

Version 1.3.114 Chromium: 80.0.3987.87 (Official Build) (64-bit)
OSX version: 10.15.2 (19C57)

We have a build now that should address this issue:

• Win x64 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup.exe
• Win x86 - https://github.com/brave/brave-browser/releases/download/v1.3.114/BraveBrowserStandaloneSetup32.exe
• macOS - https://github.com/brave/brave-browser/releases/download/v1.3.114/Brave-Browser.dmg
• Linux - https://github.com/brave/brave-browser/releases/download/v1.3.114/brave-browser_1.3.114_amd64.deb

[jonathansampson]

Thank you, @robincsamuel. Could you go to about:crashes and submit the last couple of crashes, then restart Brave, and revisit about:crashes to collect the new Crash IDs. Pleas share those here when you have a moment.

[victorelec14]

@jonathansampson , here are the last 10 crashes :) thx !

happens on :

1.3.113

and after update to :

Version 1.3.114 Chromium: 80.0.3987.87 (Official Build) (64-bit)

nightly its OK

Version 1.5.50 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)

Crashes (27)
Uploaded Crash Report ID 1be23ddcb660b2af (Local Context: a72f28d5-adb3-41b7-b90d-f8717b0b07eb)
Crash report captured on Sunday, February 9, 2020 at 11:58:24 AM, uploaded on Sunday, February 9, 2020 at 11:04:46 PM

Uploaded Crash Report ID 11a11ac320923137 (Local Context: 1dd1feff-1618-4150-be6c-a3437f328516)
Crash report captured on Sunday, February 9, 2020 at 10:10:11 AM, uploaded on Sunday, February 9, 2020 at 11:04:45 PM

Uploaded Crash Report ID e9d04bf609c98cf1 (Local Context: 143ee0bd-90ba-4ecf-bf09-3e0462e69715)
Crash report captured on Saturday, February 8, 2020 at 2:07:28 PM, uploaded on Sunday, February 9, 2020 at 11:04:44 PM

Uploaded Crash Report ID 300340f55d3de614 (Local Context: b86f97aa-edfd-4af7-bc3e-c78a7c02fd35)
Crash report captured on Saturday, February 8, 2020 at 2:02:55 PM, uploaded on Sunday, February 9, 2020 at 11:04:44 PM

Uploaded Crash Report ID c25d72df77c69d5d (Local Context: a477bd91-1b52-441e-a203-4146f0dc3d3c)
Crash report captured on Saturday, February 8, 2020 at 1:41:56 PM, uploaded on Sunday, February 9, 2020 at 11:04:43 PM

Uploaded Crash Report ID 6cd4ffddb3308907 (Local Context: 32efbae4-f5a5-4657-aac5-d6c684382fc6)
Crash report captured on Saturday, February 8, 2020 at 12:48:57 PM, uploaded on Sunday, February 9, 2020 at 11:04:42 PM

Uploaded Crash Report ID ebc5b041992a2001 (Local Context: 44513093-b904-4ffd-a0c8-f3c0538726a8)
Crash report captured on Saturday, February 8, 2020 at 12:36:15 PM, uploaded on Sunday, February 9, 2020 at 11:04:41 PM

Uploaded Crash Report ID 2ec35df153c1e1cd (Local Context: 916f6fa2-577f-4ea6-bdf6-3de6481d332f)
Crash report captured on Saturday, February 8, 2020 at 11:58:03 AM, uploaded on Sunday, February 9, 2020 at 11:04:41 PM

Uploaded Crash Report ID e4fe0c4545df690e (Local Context: b3df18f4-8c22-4d4f-9692-1f4573f79c66)
Crash report captured on Saturday, February 8, 2020 at 11:50:19 AM, uploaded on Sunday, February 9, 2020 at 11:04:40 PM

Uploaded Crash Report ID b8a9e40f0fe4fb55 (Local Context: bb121f6d-c04d-49b8-828f-f788f5f7f61f)
Crash report captured on Saturday, February 8, 2020 at 11:44:49 AM, uploaded on Sunday, February 9, 2020 at 11:04:39 PM

[lemosley01]

FYI, I re-enabled sync and it is not crashing with the new build - nothing has changed hardware or software-wise since I reported it.

[robincsamuel]

FYI, I re-enabled sync and it is not crashing with the new build - nothing has changed hardware or software-wise since I reported it.

I'm observing the same now. To summarize, Yesterday morning, for some reason, Brave wasn't staying open for even a second. I found this thread and downloaded the versions mentioned in the above comment. After that, Brave started crashing every few minutes. I turned off sync and the problem went away. Then I uploaded the crash reports and turned on sync to reproduce the issue but no crashes after that. :)

[dvmason]

@jonathansampson Brave offered upgrade on MacOS Mojave... I agreed... installed and crashed. Tried Nightly... same result... tried moving Library/Application Support/BraveSoftware/Brave-Browser out of the way... same result... tried 1.3.114... same result. Not happy... was sepending on Brave.

[robincsamuel]

I'm observing crashes again every few minutes (four times in the last 5 minutes). Uploaded crash reports, e26feb194539c74f, bd02cd5bc33c2c47

Version 1.3.114 Chromium: 80.0.3987.87 (Official Build) (64-bit)

[tmancey]

@robincsamuel @dvmason Can you please upgrade to 1.3.115 and if the issue persists please submit a crash report and let me know the crash report id. Thanks

[robincsamuel]

@tmancey I've upgraded to 1.3.115. I will upload and share the crash report id here if the issue persists. Thanks!

[robincsamuel]

I just noticed that brave://sync is not available on 1.3.115, and therefore not sure if sync is on. The issue wasn't there when I turn off sync.

[dvmason]

@tmancey I downloaded the latest (1.3.115) and it works fine. Thank you!!!!

As far as I know, I've never used sync, so that wasn't the problem.

[bracklanna]

I just noticed that brave://sync is not available on 1.3.115, and therefore not sure if sync is on. The issue wasn't there when I turn off sync.

Same here, brave://sync is turned off in 1.3.115. I do use BraveSync for bookmarks between Desktop & 2 iOS devices, and have noticed the lack of sync.

[MrHaroldA]

Same here, brave://sync is turned off in 1.3.115.

You are 2 versions behind: in 1.3.118, sync reappeared as a flag.

[StFS]

I'm using 1.5.115 on Mac and I can't find the sync option anywhere. Still, this issue is closed. Is there some other issue that is tracking the progress of whatever is going on with this? Being able to sync bookmarks is a pretty important feature for me and I'd like to avoid installing some plugin for doing that.

[MrHaroldA]

Did you enable the sync flag, as described above?

chrome://flags

[StFS]

@MrHaroldA darn it... missed that explanation.. will try, thanks for the pointer

[kjozwiak]

@StFS we added a brave://flag as mentioned by @MrHaroldA via #8187 in https://github.com/brave/brave-browser/releases/tag/v1.3.118.

[akash07k]

Hi all,
If I enable sync via flags in latest Brave Browser Version 81.1.7.98
@kjozwiak Will I face any crashes/issues? is it safe to enable?

[saschpe]

The way this issue was handled really looks amateur to me. First of all, the sync feature was disabled for 100% of the user base, while a crash might have affected a small minority. Then, all community issues are closed and don't take further comments. One has to dig up this Github issue three months later just to realise that brave://flag doesn't exist. Also, do you expect all your users to go to Github to read that random comment and mess with browser internals?

I do like Brave but this isn't the first time that issues are handled in a rather weird way. You simply should not silently break a rather important feature and let users wonder what the issue is and then not react for months...

[jsecretan]

Sorry for the confusion @saschpe, I realize that our messaging on all of this was hard to follow. We've put together a support article for getting sync v1 back on while we work on v2 https://support.brave.com/hc/en-us/articles/360042159452

[saschpe]

Thanks, that is much appreciated. Keep up the good work!

[akash07k]

Hi, Is there any ETA by when we can expect sync v2? I've enabled older sync but it is crashing my browser

…

On 4/27/20, Sascha Peilicke ***@***.***> wrote: Thanks, that is much appreciated. Keep up the good work! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #8128 (comment)

[bsclifton]

cc: @jsecretan