Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tip banner has message for connected publisher when panel does not - follow up to 7739 #8512

Closed
LaurenWags opened this issue Mar 3, 2020 · 2 comments · Fixed by brave/brave-core#4829

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #7739 , similar to #6182 (pre-VG)

While testing #7739, the panel does not contain a 'connected publisher message' but the tip banner does. In the scenario described below, neither the panel nor the tip banner should have this message.

Steps to Reproduce

  1. enable rewards on staging profile
  2. claim grant
  3. connect verified uphold wallet
  4. go to bumpsmack.com
  5. open panel, make sure that you don't see connected message
  6. open tip banner
    ---> there is a message but there should not be

Actual result:

SS1

when retesting, also do the following steps:
7. spend UGP grant
8. open both panel and tip banner, make sure that you see connected message on both places once UGP grant is all contributed.

Expected result:

In this scenario, neither panel nor tip banner should have a message until the ugp grant is spent.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.106 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? probably
  • Can you reproduce this issue with the nightly channel? probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @brave/legacy_qa

@btlechowski
Copy link

Reproduced on

Brave 1.5.106 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Ubuntu 18.04 LTS

image

@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 24, 2020

Verified passed with

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-03-24 at 12 10 29 PM

Screen Shot 2020-03-24 at 12 10 45 PM

  • Verified that if you don't have any Brave funds (ex. all the UGP is contributed or you did not have a UGP grant and you connected a KYC'd sandbox wallet), bumpsmack.com does show the connected publisher message as expected:

Screen Shot 2020-03-24 at 12 43 01 PM

Screen Shot 2020-03-24 at 12 43 17 PM

Verification passed on

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from Fixes connected message for publisher banner brave-core#4829 and steps from the description:
    image
    image
    image
  • Verified that if you don't have any Brave funds (ex. all the UGP is contributed or you did not have a UGP grant and you connected a KYC'd sandbox wallet), bumpsmack.com does show the connected publisher message as expected:

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment