Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable crypto wallets #8742

Closed
wooque opened this issue Mar 18, 2020 · 44 comments · Fixed by brave/brave-core#10191
Closed

Can't disable crypto wallets #8742

wooque opened this issue Mar 18, 2020 · 44 comments · Fixed by brave/brave-core#10191

Comments

@wooque
Copy link

wooque commented Mar 18, 2020

Description

There is no setting anymore to disable crypto wallets

Steps to Reproduce

  1. Open chrome://settings/ -> Extensions
  2. No setting to disable crypto wallets

Actual result:

There is no setting to disable crypto wallets

Expected result:

There is setting to disable crypto wallets

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) unknown (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Linux
JavaScript V8 8.0.426.26
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36
Command Line /usr/lib/brave-bin/brave --enable-features=OverlayScrollbar --disable-features=TabHoverCards --disable-smooth-scrolling --enable-gpu-rasterization --ignore-gpu-blacklist --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,SimplifyHttpsIndicator,WebUIDarkMode,OverlayScrollbar --disable-features=AllowPopupsDuringPageUnload,LookalikeUrlNavigationSuggestionsUI,NotificationTriggers,AutofillServerCommunication,AudioServiceOutOfProcess,TabHoverCards,SmsReceiver,VideoPlaybackQuality,WebXrGamepadModule,WebXR --flag-switches-begin --flag-switches-end --disable-webrtc-apm-in-audio-service --disable-sync
Executable Path /usr/lib/brave-bin/brave
Profile Path /home/vuk/.config/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? /
  • Can you reproduce this issue with the dev channel? /
  • Can you reproduce this issue with the nightly channel? /

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? /
  • Does the issue resolve itself when disabling Brave Rewards? /
  • Is the issue reproducible on the latest version of Chrome? /

Miscellaneous Information:

@bsclifton bsclifton added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 19, 2020
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 20, 2020
@eljuno
Copy link

eljuno commented Apr 5, 2020

@rohitghali
Copy link

+1 from me.

@RJVB
Copy link

RJVB commented Apr 21, 2020

+1

I noticed it popping up in the task manager, with a few percents of CPU usage. Not consistently but enough to send me on a search that made me land here.

The IPFS extension is downloaded on demand, why not do the same with this one (and any other extension that most users will probably never have use for)?

@Rhevin
Copy link

Rhevin commented Apr 28, 2020

+1 from me

@juanmcortez
Copy link

+1 from me too ...

@dandai
Copy link

dandai commented May 6, 2020

+1

1 similar comment
@say4n
Copy link

say4n commented May 8, 2020

+1

@Taomyn
Copy link

Taomyn commented May 26, 2020

+1

2 similar comments
@calebbarr
Copy link

+1

@thylux
Copy link

thylux commented May 29, 2020

+1

@Deses
Copy link

Deses commented May 30, 2020

Extension Crypto Wallets is using about 70 MB of RAM and I wish for it to be gone. I have plenty of ram but I just don't want this crap installed.

I switched from Chrome to avoid this kind of BS, and this is pretty disappointing.

Also, wtf is this?
image
If it's crypto related I just want it gone.

@RJVB
Copy link

RJVB commented May 30, 2020 via email

@Deses
Copy link

Deses commented May 30, 2020

On Friday May 29 2020 19:10:13 Carlos R wrote: Also, wtf is this? image
I've been wondering about those too. They bring back not-fond old memories of something called "The Bat" in relation to spam, so seeing "Bat Ads Service" isn't very nice.

Nothing to do with spam. BAT is their Basic Attention Token, Brave's crypto to pay creators because we block ads.

I can't even enable the thing in my country! Let me get rid of this.

@nightcometh
Copy link

+1 from me as well, this a very big negative

part of the reason people switched to brave is to avoid these type of background resources that are always on without the user's permission,
sucking resources and sending data to ???

back to seamonkey until this is resolved

@joshxyzhimself
Copy link

@Deses
Copy link

Deses commented Jun 7, 2020

https://news.ycombinator.com/item?id=23442027

Thanks for that link. I guess I'm better off going back to Chrome.

@micnguyen
Copy link

Thanks for that link. I'm also deleting Brave and going back to Chrome. This GH Issue along with that link shows to me unfortunately that the developers are not only sneaking in stuff but blatantly lying about it. Sorry guys, it was a good 3 months run with the browser.

@codybrom
Copy link

codybrom commented Jun 9, 2020

+1. Don't waste my RAM for features I've disabled.

@bbondy
Copy link
Member

bbondy commented Jun 12, 2020

Just an FYI that this is now lazy loaded with 1.10.x (which will be released either today or Monday), so it will only load Crypto Wallets if you navigate to brave://wallet.

A further change also makes it so you need to explicitly opt-in and without that it will never start it at all.

Keeping this open since there's still no option to disable it after you explicitly opt-in though. But it will be already off for most users as of 1.10.x.

@Invisible40
Copy link

Can I turn off the "Set up Crypto Wallets" banner that appears on some websites?

@marcbousaleh
Copy link

Can I turn off the "Set up Crypto Wallets" banner that appears on some websites?

That's exactly what I'm looking for, it is really annoying. Please notify me if you found a way to disable it.

@bbondy
Copy link
Member

bbondy commented Jul 27, 2020

Yes you can set Web3 provider for using Dapps setting to None in brave://settings/extensions or you can just keep it on Brave Wallet but turn on Load Crypto Wallets on startup

@xlcrr
Copy link

xlcrr commented Aug 22, 2020

Settings - Extensions - First item ( Web3 provider for Dapps) - None

Should be default. Really annoying

@Rishirandhawa
Copy link

@guttermonk I have exactly the same setup and problem. It renders it completely unusable.

@guttermonk
Copy link

Tried uninstalling MetaMask, clearing my cache, rebooting, connecting my Ledger, starting Brave, opened Crypto Wallets, and tried to "Connect Hardware Wallet" ...still getting the eternal spinner of death.

@ghost
Copy link

ghost commented Nov 11, 2020

+1

1 similar comment
@tomgo5k
Copy link

tomgo5k commented Apr 16, 2021

+1

@xanoni
Copy link

xanoni commented May 3, 2021

As a workaround, I've disabled it under "Extensions" (brave://extensions/).

image

Does anyone know what the benefit of the Brave wallet is over Metamask? I gave the Brave wallet a shot, but it complained about Trezor Connect being incompatibly versioned, so I just went back to Metamask. Thank you.

@Taomyn
Copy link

Taomyn commented May 4, 2021

@M09NST3R how do you get the extension to appear because it's not listed as one in my extension manager?

@srirambv
Copy link
Contributor

srirambv commented May 4, 2021

@Taomyn can you check what version you have from brave://components ?

@Taomyn
Copy link

Taomyn commented May 4, 2021

@srirambv not there either

image

@srirambv
Copy link
Contributor

srirambv commented May 4, 2021

@Taomyn you need to have the CW page open and then check. The component only loads when you have CW page open

@Taomyn
Copy link

Taomyn commented May 4, 2021

@Taomyn you need to have the CW page open and then check. The component only loads when you have CW page open

Ok, so maybe if I do not go beyond this when I go into Settings and click on "Crypto Wallets" then I will not have it anyway?

image

@srirambv
Copy link
Contributor

srirambv commented May 4, 2021

@Taomyn I don't think you have CW installed so not sure why you want it to be removed? If you are looking to disable/remove UI elements for CW that is not possible. You can only remove/uninstall the extension if its installed. Please see @bbondy's message above

@bbondy bbondy added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Jul 21, 2021
@bbondy
Copy link
Member

bbondy commented Sep 22, 2021

You'll be able to set the new Default wallet to none with this #18213

@MommysLilPogChamp
Copy link

+1

@bbondy
Copy link
Member

bbondy commented Nov 23, 2021

You can do this via brave://settings/wallet by setting Default cryptocurrency wallet to None and changing Show Brave Wallet icon on toolbar to off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet