Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocationBar Bookmark Star is back on Windows #899

Closed
petemill opened this issue Aug 31, 2018 · 1 comment · Fixed by brave/brave-core#379
Closed

LocationBar Bookmark Star is back on Windows #899

petemill opened this issue Aug 31, 2018 · 1 comment · Fixed by brave/brave-core#379
Assignees
@petemill
Labels
bug OS/Windows pr/pending-review QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

Looks like the #define override implemented in https://github.com/brave/brave-core/pull/343/files#diff-778cfac58ee12e6eb9fa44823c5ae57aR8 isn't working correctly on Windows, nor is the previous chromium_src solution from https://github.com/brave/brave-core/pull/280/files#diff-c93544d318feb386e99e9afc28a229a7

Both attempts show the bookmark star in the url bar (even though with 280 alone, the override worked fine). Other attempts get a build error.
@petemill petemill added this to the Releasable builds 0.55.x milestone Aug 31, 2018
@petemill petemill self-assigned this Aug 31, 2018
petemill added a commit to petemill/brave-core that referenced this issue Aug 31, 2018
@petemill
Alternative strategy for hiding original bookmark star button in loca…
433343a 
…tion bar

Fix brave/brave-browser#899
Re-definition of LocationBarView's LocationBar subclass was flakey
@petemill petemill mentioned this issue Aug 31, 2018
Merged
11 tasks
@bbondy bbondy mentioned this issue Sep 1, 2018
Closed
@bbondy bbondy added the QA/Yes label Sep 10, 2018
@btlechowski
Copy link

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

@srirambv srirambv removed the QA/Yes label Sep 25, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
bug OS/Windows pr/pending-review QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Alternative strategy for hiding original bookmark star button in location bar petemill/brave-core
4 participants
@petemill @bbondy @srirambv @btlechowski