Alternative strategy for hiding original bookmark star button in location bar #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion bar Fix brave/brave-browser#899 Re-definition of LocationBarView's LocationBar subclass was flakey
simonhong
reviewed
Sep 1, 2018
| @@ -36,6 +33,12 @@ void BraveLocationBarView::Update(const content::WebContents* contents) { | |||
| LocationBarView::Update(contents); | |||
| } | |||
|
|
|||
| void BraveLocationBarView::UpdateBookmarkStarVisibility() { | |||
| if (star_view_) { | |||
| star_view_->SetVisible(false); | |||
There was a problem hiding this comment.
Much clear than before!
How about adding a browser test to check |star_view_| is always invisible?
There was a problem hiding this comment.
I added an issue here for it:
brave/brave-browser#939
bbondy
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#899
Re-definition of LocationBarView's LocationBar subclass was flakey and now that we have a BraveLocationBarView subclass, adding an override there is lower-impact.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: