Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items icons not visible on dark mode #9261

Closed
srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5284
Closed

Menu items icons not visible on dark mode #9261

srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5284
Assignees
Labels
design A design change, especially one which needs input from the design team feature/widgets priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Menu items icons not visible on dark mode

Steps to Reproduce

  1. Set browser to dark mode
  2. Open widget menu
  3. Menu icons looks dark

Actual result:

Screenshot from 2020-04-16 05-24-03
Screenshot from 2020-04-16 05-27-24

Expected result:

Should be visible

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1909 (Build 18363.778)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support feature/widgets labels Apr 16, 2020
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 17, 2020
@ryanml ryanml self-assigned this Apr 18, 2020
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 18, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 19, 2020
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified foreground widget menu items are visible
    image
  • Verified background widget menu items are visible
    image

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified foreground widget menu items are visible
    image
  • Verified background widget menu items are visible
    image

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified foreground widget menu items are visible
    image
  • Verified background widget menu items are visible
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/widgets priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants