Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates widget menu icons per theme #5284

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Updates widget menu icons per theme #5284

merged 1 commit into from
Apr 20, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 18, 2020

Fixes brave/brave-browser#9261

Screen Shot 2020-04-17 at 6 04 21 PM

Screen Shot 2020-04-17 at 6 04 09 PM

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 18, 2020
@ryanml ryanml requested review from bbondy and emerick April 18, 2020 01:36
@ryanml ryanml self-assigned this Apr 18, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 9da3edc into master Apr 20, 2020
@ryanml ryanml deleted the fix-9261 branch April 20, 2020 16:05
bsclifton pushed a commit that referenced this pull request Apr 21, 2020
Updates widget menu icons per theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu items icons not visible on dark mode
3 participants