Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both address and Memo ID should be shown for supported coins #9605

Closed
srirambv opened this issue May 4, 2020 · 2 comments · Fixed by brave/brave-core#5465
Closed

Both address and Memo ID should be shown for supported coins #9605

srirambv opened this issue May 4, 2020 · 2 comments · Fixed by brave/brave-core#5465

Comments

@srirambv
Copy link
Contributor

srirambv commented May 4, 2020

Description

Both address and Memo ID should be shown for supported coins

Steps to Reproduce

  1. Install nightly
  2. Connect widget and go to deposit
  3. Certain coins only show Memo ID but require wallet address as well to make deposit

Actual result:

Only memo id is shown

Expected result:

Should show both memo id and wallet address to make a successful deposit

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.10.24 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Windows 10 OS Version 1909 (Build 18363.778)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

srirambv commented May 7, 2020

Verification passed on

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux
  • Verified both Memo ID and Wallet address is shown where applicable
    image
    image
    image
  • Verified copy button copies Memo ID and Wallet address to clipboard
  • Verified Memo ID and wallet address on widget matches whats on Binance portal
  • Verified Copy button next to asset name copies the memo id and matches the listed memo id

Verification passed on

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Windows 10 OS Version 1809 (Build 17763.1158)
  • Verified both Memo ID and Wallet address is shown where applicable

Screen Shot 2020-05-07 at 3 49 16 PM

Screen Shot 2020-05-07 at 3 50 39 PM

Screen Shot 2020-05-07 at 3 50 57 PM

  • Verified copy button copies Memo ID and Wallet address to clipboard
  • Verified Memo ID and wallet address on widget matches whats on Binance portal
  • Verified Copy button next to asset name copies the memo id and matches the listed memo id

Verification passed on

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified both Memo ID and Wallet address is shown where applicable

Screen Shot 2020-05-07 at 4 04 48 PM

Screen Shot 2020-05-07 at 4 04 59 PM

Screen Shot 2020-05-07 at 4 05 05 PM

  • Verified copy button copies Memo ID and Wallet address to clipboard
  • Verified Memo ID and wallet address on widget matches whats on Binance portal
  • Verified Copy button next to asset name copies the memo id and matches the listed memo id

@LaurenWags
Copy link
Member

Changing to release-notes/include per discussion with @srirambv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants