Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memo should be shown for applicable assets in Binance summary #9535

Closed
ryanml opened this issue Apr 29, 2020 · 2 comments · Fixed by brave/brave-core#5267
Closed

Memo should be shown for applicable assets in Binance summary #9535

ryanml opened this issue Apr 29, 2020 · 2 comments · Fixed by brave/brave-core#5267

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 29, 2020

Description

Currently, the deposit address is the only deposit data point taken in to account for assets. We should be using the deposit memo for assets like EOS

Test Plan:

  1. Connect via Oauth to the Binance widget
  2. Click in to EOS in the Deposit view
  3. See memo id displayed instead of a deposit address
  4. Ensure the memo can be copied
  5. Ensure the QR code scans to the memo id
  6. Ensure other assets such as BTC, ETH, and LTC show the deposit address as expected.

Screen Shot 2020-04-20 at 5 29 25 PM

@kjozwiak
Copy link
Member

kjozwiak commented May 4, 2020

Verification PASSED on macOS 10.15.4 x64 Catalina using the following build:

Brave | 1.8.89 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

Screen Shot 2020-05-04 at 12 16 34 AM

@srirambv
Copy link
Contributor

srirambv commented May 4, 2020

Verification passed on

Brave 1.8.89 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{# 979}
OS Linux

Verification passed on

Brave 1.8.89 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{# 979}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment