-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing all deposit addresses, memos in the Binance Widget. #5267
Conversation
const std::map<std::string, std::string>& balances, | ||
const std::string& asset) { | ||
std::string balance; | ||
std::string GetValueFromStringMap( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured this would just be better off as a generic prying function
ff1a7b9
to
5750d6b
Compare
chrome.binance.getCoinNetworks((networks: Record<string, string>) => { | ||
const currencies = this.getCurrencyList() | ||
for (let ticker in networks) { | ||
if (currencies.includes(ticker)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll check for only what's in the deposit list, as there are hundreds of currencies in the network endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: The |
571b3e4
to
6369dd4
Compare
…ss where applicable
Builds generated for all platforms, tests related to Binance passed, known failures for ads confirmations resulted in failure |
Showing all deposit addresses in the Binance Widget.
Reproduced the issue on
Verification PASSED on
Ran into brave/brave-browser#9250 (comment) and created brave/brave-browser#9600. |
Showing all deposit addresses in the Binance Widget.
Fixes: brave/brave-browser#9250
Fixes: brave/brave-browser#9535
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Defined in issues
Reviewer Checklist:
After-merge Checklist:
changes has landed on.