Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fav icon for youtube #986

Closed
NejcZdovc opened this issue Sep 6, 2018 · 1 comment · Fixed by brave/brave-core#574
Closed

Fav icon for youtube #986

NejcZdovc opened this issue Sep 6, 2018 · 1 comment · Fixed by brave/brave-core#574
Assignees
@jasonrsadler
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Youtube icons are currently not saving. More info here brave-intl/bat-native-ledger#83
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 6, 2018
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Oct 4, 2018
Fixes brave/brave-browser#986. Fixes #83
dda9bc6
This was referenced Oct 4, 2018
Merged
Merged
@NejcZdovc NejcZdovc reopened this Oct 8, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Oct 13, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows

image

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

image

@LaurenWags LaurenWags mentioned this issue Oct 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Favicon urls should now be populated in database
5 participants
@NejcZdovc @srirambv @jasonrsadler @LaurenWags @GeetaSarvadnya