Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon urls should now be populated in database #574

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Favicon urls should now be populated in database #574

merged 1 commit into from
Oct 8, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Oct 4, 2018

Fixes brave/brave-browser#986.
Fixes brave-intl/bat-native-ledger#83

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Open Brave and enable rewards
  2. Open youtube video on youtube website and view for required time
  3. Verify the youtube publisher avatar url is added to the database
  1. Open Brave and enable rewards
  2. Open youtube video embedded on a website separate from youtube
  3. Verify the youtube publisher avatar url is added to the database

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc merged commit 1047e2c into brave:master Oct 8, 2018
@NejcZdovc
Copy link
Contributor

master 1047e2c
0.56.x no change since #530 already updated hash
0.55.x no change since #530 already updated hash

@jasonrsadler jasonrsadler deleted the youtube_favicon_core branch October 8, 2018 10:03
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fav icon for youtube Add youtube icons
3 participants